8 Commits
Author SHA1 Message Date
Gleb Mazovetskiy 38e37e0d53 Fix warnings/errors with -funsigned-char 2022-12-05 07:52:13 +01:00
Gleb Mazovetskiy f460405818 Fix warnings
Note that in test/utf8_test.cpp, the first comparison was redundant.
For a signed char, this iterates from -128 to -1, unsigned from 0 to 128.
2022-07-14 00:19:21 +01:00
ephphatha 0fc06924fb Restructure test conditions to avoid tautology warnings 2022-06-19 18:45:45 +02:00
Andrew James 60b835214b Address warnings in Utf8 functions (#4748)
* Use explicit typecasts to force signed char comparisons

Avoids warnings about tautological comparisons (either the >= 0 comparison for ARM/PowerPC or the <= 127 comparison for x86*)

* Remove unused function
2022-06-19 13:32:22 +02:00
ephphatha e246ac78db Simplify character test in UiValidPlayerName 2022-06-18 14:02:48 +02:00
ephphatha 34b7d85263 Add IsLeadUtf8CodeUnit to complement trail byte detection 2022-06-18 14:02:48 +02:00
ephphatha 956fe7c093 Add tests for IsTrailUtf8CodeUnit 2022-06-18 14:02:48 +02:00
Gleb Mazovetskiy f22d1d0149 Remove uses of deprecated codecvt
codecvt is deprecated in C++17 and we don't really need all of its heavy
machinery for simply converting to UTF-8.
2022-06-16 13:54:29 +01:00