libretro/mgba
1
0
Fork 0
mirror of https://github.com/libretro/mgba.git synced 2024-11-30 11:40:28 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Debugger: Fix use-after-free in breakpoint clearing code (again)

Browse Source
This commit is contained in:
Jeffrey Pfau 2015-08-15 22:12:26 -07:00
parent 7a6582503f
commit 3a9ac188d4
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES
View File

@ -73,6 +73,7 @@ Bugfixes:
- GBA Video: Fix timing on first scanline - GBA Video: Fix timing on first scanline
- GBA: Ensure cycles never go negative - GBA: Ensure cycles never go negative
- Util: Fix formatting of floats - Util: Fix formatting of floats
- Debugger: Fix use-after-free in breakpoint clearing code
Misc: Misc:
- Qt: Handle saving input settings better - Qt: Handle saving input settings better
- Debugger: Free watchpoints in addition to breakpoints - Debugger: Free watchpoints in addition to breakpoints

2
src/debugger/debugger.c
View File

@ -155,6 +155,7 @@ void ARMDebuggerClearBreakpoint(struct ARMDebugger* debugger, uint32_t address)
if (breakpoint->address == address) { if (breakpoint->address == address) {
*previous = *next; *previous = *next;
free(breakpoint); free(breakpoint);
continue;
} }
previous = next; previous = next;
} }
@ -179,6 +180,7 @@ void ARMDebuggerClearWatchpoint(struct ARMDebugger* debugger, uint32_t address)
if (watchpoint->address == address) { if (watchpoint->address == address) {
*previous = *next; *previous = *next;
free(watchpoint); free(watchpoint);
continue;
} }
previous = next; previous = next;
} }