Files
Chris Dixonandlibretroadmin d4908f40fb USB: EyeToy camera and microphone, through the frontend or V4L2/ALSA on Linux (#179)
* USB/EyeToy: the EyeToy and Capture Eye device models

PCSX2's Sony EyeToy (OV519) and Konami Capture Eye (OV511+) device
models, on the libretro-usb OHCI core the HID devices already use.
Nothing attaches them yet.

Pictures come from RETRO_ENVIRONMENT_GET_CAMERA_INTERFACE when the
frontend offers it, and otherwise, on Linux, from V4L2: the first node
that streams video capture, in YUYV. Sound comes from
GET_MICROPHONE_INTERFACE, or on Linux from ALSA: the capture card on the
camera's own USB device, else any USB one. libasound is opened with
dlopen, so the core gains no library dependency. Camera frames and
microphone samples are taken on the main thread, as the libretro API
requires, and handed to the emulator thread under a lock.

Against PCSX2:
- The microphone is read straight from the EyeToy's audio endpoint, so
  the separate USB microphone device it embedded is not needed.
- Frames become RGB once, at the size the game asked for whatever the
  camera delivers, mirrored there; MPEG, JPEG and the Capture Eye's
  greyscale are all encoded from that.
- JPEG mode has its own baseline encoder (4:2:2, as libjpeg was asked
  for) instead of libjpeg.
- jo_mpeg: Cb and Cr were B-Y and R-Y without the 1.772 and 1.402
  scale, so saturated colours overflowed the DC size table and the
  stream would not decode; YUYV chroma landed in the wrong columns; AC
  levels past +-127 kept an MPEG-1 prefix inside the MPEG-2 escape.
- The frame size the game writes is clamped to the 640x480 the buffers
  hold.

* libretro: the USB Camera option plugs an EyeToy in

System > USB Camera puts a Sony EyeToy or a Konami Capture Eye on the
first USB port that no keyboard or mouse holds. The frontend's camera
and microphone are asked for in retro_load_game, only when the option
is on, and pumped from retro_run; the per-frame HID update leaves the
camera's port alone.

* USB: savestates hold the controller and its devices

USBfreeze was a stub, so loading a state left the guest's USB driver
talking to a controller and devices that had forgotten their addresses,
configuration and registers; a keyboard, mouse or EyeToy in use stopped
answering.

The state gains a fixed-size USB block just before the extension block,
with a footer of its own: the OHCI registers, then per port what every
USB device has (address, configuration, endpoints) and what the device
adds, the HID event queues or the EyeToy's and its sensor's registers.
The EyeToy's frame in flight is not kept; it starts a new one. A state
without the block, or one whose ports held other devices, plugs those
devices in afresh, as PCSX2 does.

* USB/EyeToy: lock-free frame and sample handoffs, stack frames in budget, state slots validated, harnesses

The camera frame and the microphone samples crossed from the thread that
captures (the frontend's camera callback, or the V4L2 thread) to the one
that runs the device under a mutex, with GetImage copying the frame while
holding it. They now cross through two primitives in cam-frame.h built for
exactly that, on libretro-common atomics and nothing else. FrameMailbox is
three buffers and one exchanged slot: the producer encodes into its own,
publishes by swapping it into the slot, and the consumer swaps its own in
to take the newest; a frame published while the consumer is away is simply
replaced. SampleRing is a single-producer single-consumer ring; a full ring
drops at the producer, and the consumer trims its own backlog by advancing
its own index. What the device asked of the camera - wanted, format,
mirror, size, generation - travels in one atomic word, so an Open from the
emulator thread and a frame from the main thread never meet in a lock.

The stackframe lane was over budget on four new frames: the JPEG encoder
built its four Huffman tables on the stack per call, jo_write_mpeg kept its
macroblock scratch there, and the ALSA device search had two PATH_MAX
buffers. The tables are built once as statics, the scratch is a
FrameEncoder the caller owns, and realpath allocates.

A savestate slot naming a configuration or interface the device does not
have was half loaded and the device left running on it; the slot is now an
error, and a port whose slot errs, or holds another device, is cycled with
usb_port_reset, so the device model is at its defaults as a guest's port
reset would leave it.

tests/cam runs the mailbox and the ring from two threads, plain and under
TSan, and parses what the JPEG, IPU and YUV400 encoders emit; tests/usbstate
drives the real controller and device models through write, strip and read,
and the states that must replug: no block, another device on the port, a
bad configuration, a bad interface. Both run from run-all.sh.

---------

Co-authored-by: libretroadmin <[email protected]>
2026-10-17 20:17:25 +02:00

358 lines
11 KiB
C++

// EyeToy frame and sample handoff, and the encoders behind them.
//
// FrameMailbox and SampleRing (pcsx2/USB/usb-eyetoy/cam-frame.h) are the
// lock-free handoffs between the thread that captures (the frontend's camera
// callback or the V4L2 thread) and the thread that runs the device. A
// producer and a consumer hammer each from two threads: every frame taken
// must be whole and never older than the one before, every sample run must
// be in order. Built with TSan too, since the two share nothing but the
// primitive.
//
// The encoders are checked by parsing what they emit: a JFIF the game's
// decoder would accept, with the component layout the EyeToy sends; an IPU
// stream with its header and end-of-sequence; the Capture Eye's 80x64 block
// layout, sampled every fourth pixel.
#include "cam-frame.h"
#include "cam-jpeg.h"
#include "jo_mpeg.h"
#include <pthread.h>
#include <sched.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
using namespace usb_eyetoy;
static int s_bad;
static void check(bool ok, const char* what)
{
printf(" %-56s %s\n", what, ok ? "ok" : "WRONG");
if (!ok)
s_bad++;
}
/* ---- FrameMailbox ---- */
static const u32 MAILBOX_FRAMES = 20000;
// A frame is its sequence number, repeated; size varies with it.
static u32 frame_size(u32 seq)
{
return 64 + (seq * 7919) % 4096;
}
static void* mailbox_producer(void* arg)
{
FrameMailbox* m = static_cast<FrameMailbox*>(arg);
for (u32 seq = 1; seq <= MAILBOX_FRAMES; seq++)
{
u8* w = m->Work();
const u32 size = frame_size(seq);
for (u32 i = 0; i < size; i++)
w[i] = static_cast<u8>(seq + i);
m->Publish(size, seq);
}
return nullptr;
}
static void test_mailbox()
{
FrameMailbox m = {};
check(m.Init(), "mailbox allocates");
check(m.Take() == nullptr, "mailbox starts empty");
pthread_t t;
pthread_create(&t, nullptr, mailbox_producer, &m);
u32 last = 0, taken = 0, torn = 0, backwards = 0;
while (last < MAILBOX_FRAMES)
{
const FrameMailbox::Buffer* f = m.Take();
if (!f)
continue;
taken++;
if (f->generation <= last)
backwards++;
if (f->size != frame_size(f->generation))
torn++;
else
for (u32 i = 0; i < f->size; i++)
if (f->data[i] != static_cast<u8>(f->generation + i))
{
torn++;
break;
}
// The buffer is the consumer's until the next Take: read it twice.
if (f->data[0] != static_cast<u8>(f->generation))
torn++;
last = f->generation;
}
pthread_join(t, nullptr);
check(torn == 0, "every frame taken is whole");
check(backwards == 0, "frames never go backwards");
check(last == MAILBOX_FRAMES, "the last frame published is taken");
check(taken <= MAILBOX_FRAMES, "no frame is taken twice");
check(m.Take() == nullptr, "nothing left after the last");
printf(" %u published, %u taken\n", MAILBOX_FRAMES, taken);
// Reset clears what is in flight.
u8* w = m.Work();
w[0] = 1;
m.Publish(1, 99);
m.Reset();
check(m.Take() == nullptr, "Reset drops the frame in flight");
m.Free();
}
/* ---- SampleRing ---- */
// Fewer than 32768 a round, so a 16-bit sample is its own sequence number
// with no wrap, and "later" is just "greater".
static const u32 RING_SAMPLES = 30000;
static const u32 RING_ROUNDS = 25;
static retro_atomic_int_t s_ring_done;
static u32 s_ring_dropped;
static void* ring_producer(void* arg)
{
SampleRing* r = static_cast<SampleRing*>(arg);
s_ring_dropped = 0;
for (u32 i = 0; i < RING_SAMPLES; i++)
{
// A full ring drops the sample, as the frontend side does.
if (!r->Push(static_cast<s16>(i)))
s_ring_dropped++;
if ((i & 1023) == 0)
sched_yield();
}
retro_atomic_store_release_int(&s_ring_done, 1);
return nullptr;
}
static void test_ring()
{
SampleRing* r = static_cast<SampleRing*>(malloc(sizeof(SampleRing)));
r->Reset();
check(r->Count() == 0 && r->Space() == SampleRing::MASK, "ring starts empty");
// Single-threaded: fill, trim, pop.
for (u32 i = 0; i < 100; i++)
r->Push(static_cast<s16>(i));
check(r->Count() == 100, "100 pushed");
r->TrimTo(20);
s16 out[64];
u32 n = r->Pop(out, 64);
check(n == 20 && out[0] == 80 && out[19] == 99, "TrimTo keeps the newest 20");
check(r->Count() == 0, "popped empty");
for (u32 i = 0; i < SampleRing::SIZE + 10; i++)
r->Push(0);
check(r->Count() == SampleRing::MASK && r->Space() == 0, "a full ring holds SIZE-1 and drops");
// Two threads, several rounds: every sample is read once in order, or
// was dropped by the producer on a full ring; nothing is read twice,
// nothing comes back out of order, nothing is lost in between.
u32 disorder = 0, lost = 0, total_got = 0, total_dropped = 0;
for (u32 round = 0; round < RING_ROUNDS; round++)
{
r->Reset();
retro_atomic_int_init(&s_ring_done, 0);
pthread_t t;
pthread_create(&t, nullptr, ring_producer, r);
u32 got = 0;
int last = -1;
while (!retro_atomic_load_acquire_int(&s_ring_done) || r->Count())
{
n = r->Pop(out, 64);
if (n == 0)
{
sched_yield();
continue;
}
for (u32 i = 0; i < n; i++)
{
const int v = static_cast<u16>(out[i]);
if (v <= last)
{
if (disorder < 3)
printf(" disorder: %d then %d (pop %u of %u)\n", last, v, i, n);
disorder++;
}
last = v;
got++;
}
}
pthread_join(t, nullptr);
if (got + s_ring_dropped != RING_SAMPLES)
lost++;
total_got += got;
total_dropped += s_ring_dropped;
}
check(disorder == 0, "samples are read in the order pushed, none twice");
check(lost == 0, "every sample is read or was dropped on full");
printf(" %u rounds: %u pushed, %u read, %u dropped on full\n", RING_ROUNDS, RING_SAMPLES * RING_ROUNDS, total_got, total_dropped);
free(r);
}
/* ---- Encoders ---- */
static u8* make_rgb(int w, int h)
{
u8* rgb = static_cast<u8*>(malloc(static_cast<size_t>(w) * h * 3));
for (int y = 0; y < h; y++)
for (int x = 0; x < w; x++)
{
u8* p = rgb + (y * w + x) * 3;
// Hard edges, so the MPEG escape path (|AC| > 127) is taken.
const u8 c = ((x / 8 + y / 8) & 1) ? 255 : 0;
p[0] = c;
p[1] = static_cast<u8>(x * 255 / w);
p[2] = static_cast<u8>(255 - c);
}
return rgb;
}
static u16 be16(const u8* p)
{
return static_cast<u16>((p[0] << 8) | p[1]);
}
static void test_jpeg(int w, int h)
{
u8* rgb = make_rgb(w, h);
u8* out = static_cast<u8*>(malloc(MAX_FRAME_SIZE));
const u32 n = CompressCamJPEG(out, MAX_FRAME_SIZE, rgb, w, h, 80);
char what[96];
snprintf(what, sizeof(what), "JPEG %dx%d: encodes", w, h);
check(n > 0 && n < MAX_FRAME_SIZE, what);
bool soi = n > 4 && out[0] == 0xFF && out[1] == 0xD8;
bool eoi = n > 4 && out[n - 2] == 0xFF && out[n - 1] == 0xD9;
bool sof = false, sos = false, dqt = false, dht = false, app0 = false;
// Walk the marker segments up to SOS.
u32 pos = 2;
while (pos + 4 <= n && out[pos] == 0xFF)
{
const u8 marker = out[pos + 1];
const u16 len = be16(out + pos + 2);
if (marker == 0xDA)
{
sos = true;
break;
}
if (marker == 0xE0)
app0 = len >= 16 && !memcmp(out + pos + 4, "JFIF", 5);
if (marker == 0xDB)
dqt = len == 2 + 65 * 2;
if (marker == 0xC4)
dht = true;
if (marker == 0xC0)
{
const u8* p = out + pos + 4;
// precision 8, height, width, 3 components: Y 2x1 table 0, Cb 1x1 table 1, Cr 1x1 table 1
sof = len == 17 && p[0] == 8 && be16(p + 1) == h && be16(p + 3) == w && p[5] == 3 &&
p[6] == 1 && p[7] == 0x21 && p[8] == 0 &&
p[9] == 2 && p[10] == 0x11 && p[11] == 1 &&
p[12] == 3 && p[13] == 0x11 && p[14] == 1;
}
pos += 2 + len;
}
snprintf(what, sizeof(what), "JPEG %dx%d: SOI, JFIF, DQT, SOF0 (4:2:2), DHT, SOS, EOI", w, h);
check(soi && app0 && dqt && sof && dht && sos && eoi, what);
// Entropy-coded data never holds a bare 0xFF (it is stuffed), except the EOI marker.
bool stuffed = true;
for (u32 i = pos + 2 + be16(out + pos + 2); i + 1 < n - 2; i++)
if (out[i] == 0xFF && out[i + 1] != 0x00)
stuffed = false;
snprintf(what, sizeof(what), "JPEG %dx%d: 0xFF bytes in the scan are stuffed", w, h);
check(stuffed, what);
snprintf(what, sizeof(what), "JPEG %dx%d: a short buffer returns 0", w, h);
check(CompressCamJPEG(out, n / 2, rgb, w, h, 80) == 0, what);
free(out);
free(rgb);
}
static void test_mpeg()
{
const int w = 320, h = 240;
u8* rgb = make_rgb(w, h);
u8* out = static_cast<u8*>(malloc(MAX_FRAME_SIZE));
FrameEncoder* enc = static_cast<FrameEncoder*>(malloc(sizeof(FrameEncoder)));
const u32 n = EncodeFrame(enc, out, rgb, w, h, format_mpeg);
check(n > 16 && n < MAX_FRAME_SIZE, "MPEG 320x240: encodes");
// "ipum", zeros, width and height little-endian.
check(!memcmp(out, "ipum\0\0\0\0", 8) && out[8] == (w & 0xFF) && out[9] == (w >> 8) &&
out[10] == (h & 0xFF) && out[11] == (h >> 8),
"MPEG 320x240: IPU header");
check(out[n - 4] == 0x00 && out[n - 3] == 0x00 && out[n - 2] == 0x01 && out[n - 1] == 0xB0,
"MPEG 320x240: ends on end-of-sequence");
// Deterministic: the same picture encodes to the same bytes.
u8* out2 = static_cast<u8*>(malloc(MAX_FRAME_SIZE));
const u32 n2 = EncodeFrame(enc, out2, rgb, w, h, format_mpeg);
check(n2 == n && !memcmp(out, out2, n), "MPEG 320x240: deterministic");
free(out2);
free(enc);
free(out);
free(rgb);
}
static void test_yuv400()
{
const int w = 320, h = 240;
u8* rgb = static_cast<u8*>(malloc(static_cast<size_t>(w) * h * 3));
// Grey = (x/4 + y/4 * 80) & 0xFF: every sampled pixel is its own index.
for (int y = 0; y < h; y++)
for (int x = 0; x < w; x++)
{
const u8 g = static_cast<u8>((x / 4 + (y / 4) * 80) & 0xFF);
u8* p = rgb + (y * w + x) * 3;
p[0] = p[1] = p[2] = g;
}
u8* out = static_cast<u8*>(malloc(MAX_FRAME_SIZE));
FrameEncoder* enc = static_cast<FrameEncoder*>(malloc(sizeof(FrameEncoder)));
const u32 n = EncodeFrame(enc, out, rgb, w, h, format_yuv400);
check(n == 80 * 64, "YUV400: 80x64 bytes");
bool layout = true;
u32 pos = 0;
for (int my = 0; my < 8 && layout; my++)
for (int mx = 0; mx < 10 && layout; mx++)
for (int y = 0; y < 8 && layout; y++)
for (int x = 0; x < 8; x++, pos++)
{
const int sx = 8 * mx + x, sy = 8 * my + y;
// In the picture the grey comes back through the float luma sum,
// which can land one below; past it, 0x01.
const int expect = (4 * sy < h) ? ((sx + sy * 80) & 0xFF) : 0x01;
const int diff = static_cast<int>(out[pos]) - expect;
if (diff < -1 || diff > 0 || (4 * sy >= h && diff != 0))
{
layout = false;
break;
}
}
check(layout, "YUV400: 8x8 blocks of every fourth pixel, 0x01 past the picture");
free(enc);
free(out);
free(rgb);
}
int main()
{
printf("== FrameMailbox ==\n");
test_mailbox();
printf("== SampleRing ==\n");
test_ring();
printf("== encoders ==\n");
test_jpeg(320, 240);
test_jpeg(100, 60);
test_mpeg();
test_yuv400();
printf(s_bad ? "FAIL\n" : "PASS\n");
return s_bad ? 1 : 0;
}