libretro/pcsx2
1
0
Fork 0
mirror of https://github.com/libretro/pcsx2.git synced 2024-12-28 04:35:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "gsdx-ogl: add a new hack to force anisotropic filtering"

Browse Source 
This reverts commit 53690cf9d0.

Quoting user:

 For aliasing, the option allow of reduce a little but always very
 visible compared with DX11 even with anisotropic OFF, , furthermore
 many textures bug added with option activated (predictable but not see
 on DX11 with anisotropic ON).

TL;DR doesn't worth it.

Note: it seem to work on DX because DX uses HW texturing in clamp region
mode (and others invalid case). OpenGL uses SW texturing to ensure accuracy
This commit is contained in:
Gregory Hainaut 2016-04-10 17:30:49 +02:00
parent 2941adf364
commit 847b57907e
5 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/GSdx/GSLinuxDialog.cpp
View File

@ -339,7 +339,6 @@ void populate_hack_table(GtkWidget* hack_table)
GtkWidget* hack_safe_fbmask = CreateCheckBox("Safe Accurate Blending", "UserHacks_safe_fbmask");
GtkWidget* hack_fast_inv = CreateCheckBox("Fast Texture Invalidation", "UserHacks_DisablePartialInvalidation");
GtkWidget* hack_depth_check = CreateCheckBox("Disable Depth Emulation", "UserHacks_DisableDepthSupport");
GtkWidget* hack_force_aniso = CreateCheckBox("Force Anisotropic Filtering", "UserHacks_ForceAniso");
GtkWidget* hack_sprite_box = CreateComboBoxFromVector(theApp.m_gs_hack, "UserHacks_SpriteHack");
GtkWidget* hack_sprite_label = left_label("Alpha-Sprite Hack:");
@ -361,7 +360,6 @@ void populate_hack_table(GtkWidget* hack_table)
AddTooltip(hack_safe_fbmask, IDC_SAFE_FBMASK);
AddTooltip(hack_fast_inv, IDC_FAST_TC_INV);
AddTooltip(hack_depth_check, IDC_TC_DEPTH);
AddTooltip(hack_force_aniso, IDC_FORCE_ANISO);
s_table_line = 0;
@ -369,7 +367,7 @@ void populate_hack_table(GtkWidget* hack_table)
InsertWidgetInTable(hack_table , hack_wild_check , align_sprite_check);
InsertWidgetInTable(hack_table , hack_offset_check , preload_gs_check);
InsertWidgetInTable(hack_table , hack_safe_fbmask , hack_fast_inv);
InsertWidgetInTable(hack_table , hack_depth_check , hack_force_aniso);
InsertWidgetInTable(hack_table , hack_depth_check);
InsertWidgetInTable(hack_table , hack_sprite_label , hack_sprite_box );
InsertWidgetInTable(hack_table , stretch_hack_label , stretch_hack_box );
InsertWidgetInTable(hack_table , hack_skipdraw_label , hack_skipdraw_spin);

7
plugins/GSdx/GSRendererOGL.cpp
View File

@ -27,10 +27,9 @@
GSRendererOGL::GSRendererOGL()
: GSRendererHW(new GSTextureCacheOGL(this))
{
m_accurate_date = theApp.GetConfig("accurate_date", 0);
m_sw_blending = theApp.GetConfig("accurate_blending_unit", 1);
m_accurate_date = theApp.GetConfig("accurate_date", 0);
m_force_aniso = theApp.GetConfig("UserHacks", 0) && theApp.GetConfig("UserHacks_ForceAniso", 0);
m_sw_blending = theApp.GetConfig("accurate_blending_unit", 1);
// Hope nothing requires too many draw calls.
m_drawlist.reserve(2048);
@ -988,7 +987,7 @@ void GSRendererOGL::DrawPrims(GSTexture* rt, GSTexture* ds, GSTextureCache::Sour
ps_ssel.tau = (m_context->CLAMP.WMS != CLAMP_CLAMP);
ps_ssel.tav = (m_context->CLAMP.WMT != CLAMP_CLAMP);
ps_ssel.ltf = bilinear && simple_sample;
ps_ssel.aniso = simple_sample || (m_force_aniso && !tex->m_palette);
ps_ssel.aniso = simple_sample;
// Setup Texture ressources
dev->SetupSampler(ps_ssel);

5
plugins/GSdx/GSRendererOGL.h
View File

@ -46,10 +46,9 @@ class GSRendererOGL final : public GSRendererHW
private:
bool m_accurate_date;
int m_sw_blending;
bool m_force_aniso;
bool m_unsafe_fbmask;
int m_sw_blending;
PRIM_OVERLAP m_prim_overlap;
bool m_unsafe_fbmask;
vector<size_t> m_drawlist;
unsigned int UserHacks_TCOffset;

3
plugins/GSdx/GSSetting.cpp
View File

@ -137,9 +137,6 @@ const char* dialog_message(int ID, bool* updateText) {
case IDC_FAST_TC_INV:
return "By default, the texture cache handles partial invalidations. Unfortunately it is very costly to compute CPU wise."
"\n\nThis hack replaces the partial invalidation with a complete deletion of the texture to reduce the CPU load.\n\nIt helps snowblind engine game.";
case IDC_FORCE_ANISO:
return "Force Anisotropic filtering even when it will be mathematically incorrect.\n"
"It helps to remove aliasing but it can create glitches around texture boundaries";
#endif
default:
if (updateText)

1
plugins/GSdx/GSSetting.h
View File

@ -74,6 +74,5 @@ enum {
IDC_MIPMAP,
IDC_PRELOAD_GS,
IDC_FAST_TC_INV,
IDC_FORCE_ANISO,
};
#endif