libretro/ppsspp
1
0
Fork 0
mirror of https://github.com/libretro/ppsspp.git synced 2025-02-27 12:05:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Mutexes go in FIFO order as expected.

Browse Source 
The test was wrong.
This commit is contained in:
Unknown W. Brackets 2012-11-14 23:14:41 -08:00
parent 4cddd3092a
commit 4bab714db5
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Core/HLE/sceKernelMutex.cpp
View File

@ -184,9 +184,8 @@ void sceKernelUnlockMutex(u32 id, u32 count)
// TODO: PSP_MUTEX_ATTR_PRIORITY
bool wokeThreads = false;
// TODO: Seems to go in reverse order. Maybe do more testing / related to creation order?
std::vector<SceUID>::reverse_iterator iter, rend;
for (iter = mutex->waitingThreads.rbegin(), rend = mutex->waitingThreads.rend(); iter != rend; ++iter)
std::vector<SceUID>::iterator iter, end;
for (iter = mutex->waitingThreads.begin(), end = mutex->waitingThreads.end(); iter != end; ++iter)
{
SceUID threadID = *iter;
int wVal = (int)__KernelGetWaitValue(threadID, error);
@ -196,8 +195,7 @@ void sceKernelUnlockMutex(u32 id, u32 count)
__KernelResumeThreadFromWait(threadID);
wokeThreads = true;
// Plus/minus 0 - need an iterator not a reverse_iterator.
mutex->waitingThreads.erase((++iter).base());
mutex->waitingThreads.erase(iter);
break;
}