libretro/ppsspp
1
0
Fork 0
mirror of https://github.com/libretro/ppsspp.git synced 2024-11-25 01:00:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve performance of ForgetFunctions().

Browse Source 
Mostly matters during shutdown, but also module unload.
This commit is contained in:
Unknown W. Brackets 2014-11-02 17:32:04 -08:00
parent 24ce3d11ed
commit 56322bdad4
1 changed files with 21 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
Core/MIPS/MIPSAnalyst.cpp
View File

@ -36,7 +36,8 @@
using namespace MIPSCodeUtils;
// Not in a namespace because MSVC's debugger doesn't like it
static std::vector<MIPSAnalyst::AnalyzedFunction> functions;
typedef std::vector<MIPSAnalyst::AnalyzedFunction> FunctionsVector;
static FunctionsVector functions;
recursive_mutex functions_lock;
// TODO: Try multimap instead
@ -1021,19 +1022,30 @@ skip:
// the easy way of saving a hashmap by unloading and loading a game. I added
// an alternative way.
// TODO: speedup
auto iter = functions.begin();
while (iter != functions.end()) {
if (iter->start >= startAddr && iter->start <= endAddr) {
iter = functions.erase(iter);
} else {
iter++;
// Most of the time, functions from the same module will be contiguous in functions.
FunctionsVector::iterator prevMatch = functions.end();
for (auto iter = functions.begin(); iter != functions.end(); ++iter) {
const bool hadPrevMatch = prevMatch != functions.end();
const bool match = iter->start >= startAddr && iter->start <= endAddr;
if (!hadPrevMatch && match) {
// Entering a range.
prevMatch = iter;
} else if (hadPrevMatch && !match) {
// Left a range.
iter = functions.erase(prevMatch, iter);
prevMatch = functions.end();
}
}
if (prevMatch != functions.end()) {
// Cool, this is the fastest way.
functions.erase(prevMatch, functions.end());
}
RestoreReplacedInstructions(startAddr, endAddr);
// TODO: Also wipe them from hash->function map
// TODO: Also wipe them from hash->function map.
// It should be fine not to though, since a collision is not likely.
}
void ReplaceFunctions() {