libretro/ppsspp
1
0
Fork 0
mirror of https://github.com/libretro/ppsspp.git synced 2024-11-25 17:19:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid corrupting mem if our framebuf size is wrong.

Browse Source 
Let the size specify the framebuffer height, which we are most likely to
have gotten wrong.
This commit is contained in:
Unknown W. Brackets 2014-06-10 00:15:05 -07:00
parent d5aae5a705
commit 5bd1d9d009
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
GPU/GLES/Framebuffer.cpp
View File

@ -2071,8 +2071,13 @@ bool FramebufferManager::NotifyFramebufferCopy(u32 src, u32 dst, int size, bool
} else if (srcBuffer) {
WARN_LOG_REPORT_ONCE(btdcpy, G3D, "Memcpy fbo download %08x -> %08x", src, dst);
if (g_Config.bBlockTransferGPU) {
// TODO: Validate x/y/w/h based on size and offset?
ReadFramebufferToMemory(srcBuffer, true, 0, 0, srcBuffer->width, srcBuffer->height);
// TODO: Support memcpy from offset within framebuffer? Seems dangerous.
// Maybe at least if x offset is 0, in case a game manually copies or memsets by stride.
const u32 srcBpp = srcBuffer->format == GE_FORMAT_8888 ? 4 : 2;
int h = size / (srcBuffer->fb_stride * srcBpp);
if (h > 0) {
ReadFramebufferToMemory(srcBuffer, true, 0, 0, srcBuffer->width, h);
}
}
return false;
} else {