libretro/ppsspp
1
0
Fork 0
mirror of https://github.com/libretro/ppsspp.git synced 2024-11-26 01:40:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't return errors in sceSasSetPause().

Browse Source 
-1 is perfectly valid, we just need to not infinite loop in that case by
using a logical shift not an arithmetic one.
This commit is contained in:
Unknown W. Brackets 2013-06-12 07:56:53 -07:00
parent 486f88e390
commit 8e7c5be2e0
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Core/HLE/sceSas.cpp
View File

@ -210,15 +210,14 @@ u32 sceSasGetPauseFlag(u32 core) {
return pauseFlag;
}
u32 sceSasSetPause(u32 core, int voicebit, int pause) {
u32 sceSasSetPause(u32 core, u32 voicebit, int pause) {
DEBUG_LOG(HLE,"sceSasSetPause(%08x, %08x, %i)", core, voicebit, pause);
for (int i = 0; voicebit != 0; i++, voicebit >>= 1) {
for (int i = 0; voicebit != 0; i++, voicebit >>= 1) {
if (i < PSP_SAS_VOICES_MAX && i >= 0) {
if ((voicebit & 1) != 0)
sas->voices[i].paused = pause ? true : false;
} else // TODO: Correct error code? Mimana crashes otherwise.
return ERROR_SAS_INVALID_VOICE;
}
}
return 0;
@ -505,7 +504,7 @@ const HLEFunction sceSasCore[] =
{0x33d4ab37, WrapU_UI<sceSasRevType>, "__sceSasRevType"},
{0x267a6dd2, WrapU_UII<sceSasRevParam>, "__sceSasRevParam"},
{0x2c8e6ab3, WrapU_U<sceSasGetPauseFlag>, "__sceSasGetPauseFlag"},
{0x787d04d5, WrapU_UII<sceSasSetPause>, "__sceSasSetPause"},
{0x787d04d5, WrapU_UUI<sceSasSetPause>, "__sceSasSetPause"},
{0xa232cbe6, WrapU_UII<sceSasSetTriangularWave>, "__sceSasSetTrianglarWave"}, // Typo.
{0xd5ebbbcd, WrapU_UII<sceSasSetSteepWave>, "__sceSasSetSteepWave"},
{0xBD11B7C2, WrapU_U<sceSasGetGrain>, "__sceSasGetGrain"},