libretro/ppsspp
1
0
Fork 0
mirror of https://github.com/libretro/ppsspp.git synced 2025-02-13 05:00:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Validate addresses when analyzing atrac.

Browse Source
This commit is contained in:
Unknown W. Brackets 2013-03-13 22:59:07 -07:00
parent f88bf8bbff
commit 9dddd0d90d
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Core/HLE/sceAtrac.cpp
View File

@ -133,6 +133,11 @@ void Atrac::Analyze()
ERROR_LOG(HLE, "Atrac buffer very small: %d", first.size);
return;
}
if (!Memory::IsValidAddress(first.addr))
{
WARN_LOG(HLE, "Atrac buffer at invalid address: %08x-%08x", first.addr, first.size);
return;
}
// TODO: Validate stuff.
@ -142,6 +147,12 @@ void Atrac::Analyze()
u32 offset = 12;
while (first.size > offset + 8)
{
if (!Memory::IsValidAddress(first.addr + offset))
{
ERROR_LOG(HLE, "Atrac buffer %08x-%08x not valid at %08x", first.addr, first.addr + first.size, first.addr + offset);
return;
}
u32 magic = Memory::Read_U32(first.addr + offset);
u32 size = Memory::Read_U32(first.addr + offset + 4);
offset += 8;