GPU: Add setting to control inflight frame usage.

This commit is contained in:
Unknown W. Brackets 2020-02-29 23:40:55 -08:00
parent e7ddc94fb9
commit a91e206926
12 changed files with 55 additions and 4 deletions

View File

@ -285,6 +285,14 @@ void VulkanContext::EndFrame() {
}
}
void VulkanContext::UpdateInflightFrames(int n) {
assert(n >= 1 && n <= MAX_INFLIGHT_FRAMES);
inflightFrames_ = n;
if (curFrame_ >= inflightFrames_) {
curFrame_ = 0;
}
}
void VulkanContext::WaitUntilQueueIdle() {
// Should almost never be used
vkQueueWaitIdle(gfx_queue_);

View File

@ -249,6 +249,8 @@ public:
int GetInflightFrames() const {
return inflightFrames_;
}
// Don't call while a frame is in progress.
void UpdateInflightFrames(int n);
int GetCurFrame() const {
return curFrame_;

View File

@ -772,6 +772,8 @@ static ConfigSetting graphicsSettings[] = {
ConfigSetting("GfxDebugSplitSubmit", &g_Config.bGfxDebugSplitSubmit, false, false, false),
ConfigSetting("LogFrameDrops", &g_Config.bLogFrameDrops, false, true, false),
ConfigSetting("UseInflightFrames", &g_Config.bUseInflightFrames, true, true, true),
ConfigSetting(false),
};

View File

@ -195,6 +195,7 @@ public:
std::string sPostShaderName; // Off for off.
bool bGfxDebugOutput;
bool bGfxDebugSplitSubmit;
bool bUseInflightFrames;
// Sound
bool bEnableSound;

View File

@ -78,7 +78,7 @@ size_t RamCachingFileLoader::ReadAt(s64 absolutePos, size_t bytes, void *data, F
size_t bytesFromCache = ReadFromCache(absolutePos + readSize, bytes - readSize, (u8 *)data + readSize);
readSize += bytesFromCache;
if (bytesFromCache == 0) {
// We can't read any more.
// We can't read any more.
break;
}
}

View File

@ -97,6 +97,9 @@ GPU_GLES::GPU_GLES(GraphicsContext *gfxCtx, Draw::DrawContext *draw)
textureCacheGL_->NotifyConfigChanged();
GLRenderManager *rm = (GLRenderManager *)draw_->GetNativeObject(Draw::NativeObject::RENDER_MANAGER);
rm->UseInflightFrames(g_Config.bUseInflightFrames);
// Load shader cache.
std::string discID = g_paramSFO.GetDiscID();
if (discID.size()) {
@ -355,6 +358,9 @@ void GPU_GLES::BeginHostFrame() {
GPUCommon::BeginHostFrame();
UpdateCmdInfo();
if (resized_) {
GLRenderManager *rm = (GLRenderManager *)draw_->GetNativeObject(Draw::NativeObject::RENDER_MANAGER);
rm->UseInflightFrames(g_Config.bUseInflightFrames);
CheckGPUFeatures();
framebufferManager_->Resized();
drawEngine_.Resized();

View File

@ -28,7 +28,6 @@
#include "Core/Config.h"
#include "Core/Debugger/Breakpoints.h"
#include "Core/MemMapHelpers.h"
#include "Core/Config.h"
#include "Core/Reporting.h"
#include "Core/System.h"
#include "Core/ELF/ParamSFO.h"
@ -99,6 +98,8 @@ GPU_Vulkan::GPU_Vulkan(GraphicsContext *gfxCtx, Draw::DrawContext *draw)
if (vulkan_->GetDeviceFeatures().enabled.wideLines) {
drawEngine_.SetLineWidth(PSP_CoreParameter().renderWidth / 480.0f);
}
VulkanRenderManager *rm = (VulkanRenderManager *)draw_->GetNativeObject(Draw::NativeObject::RENDER_MANAGER);
rm->UseInflightFrames(g_Config.bUseInflightFrames);
// Load shader cache.
std::string discID = g_paramSFO.GetDiscID();
@ -276,6 +277,9 @@ void GPU_Vulkan::BeginHostFrame() {
UpdateCmdInfo();
if (resized_) {
VulkanRenderManager *rm = (VulkanRenderManager *)draw_->GetNativeObject(Draw::NativeObject::RENDER_MANAGER);
rm->UseInflightFrames(g_Config.bUseInflightFrames);
CheckGPUFeatures();
// In case the GPU changed.
BuildReportingInfo();

View File

@ -345,6 +345,14 @@ void GameSettingsScreen::CreateViews() {
graphicsSettings->Add(new CheckBox(&g_Config.bVSync, gr->T("VSync")));
#endif
if (GetGPUBackend() == GPUBackend::VULKAN || GetGPUBackend() == GPUBackend::OPENGL) {
CheckBox *inflightFrames = graphicsSettings->Add(new CheckBox(&g_Config.bUseInflightFrames, gr->T("Buffer graphics commands (faster, input lag)")));
inflightFrames->OnClick.Add([=](EventParams &e) {
NativeMessageReceived("gpu_resized", "");
return UI::EVENT_CONTINUE;
});
}
CheckBox *hwTransform = graphicsSettings->Add(new CheckBox(&g_Config.bHardwareTransform, gr->T("Hardware Transform")));
hwTransform->OnClick.Handle(this, &GameSettingsScreen::OnHardwareTransform);
hwTransform->SetDisabledPtr(&g_Config.bSoftwareRendering);

View File

@ -166,7 +166,7 @@ bool GLRenderManager::ThreadFrame() {
do {
if (nextFrame) {
threadFrame_++;
if (threadFrame_ >= MAX_INFLIGHT_FRAMES)
if (threadFrame_ >= inflightFrames_)
threadFrame_ = 0;
}
FrameData &frameData = frameData_[threadFrame_];
@ -449,7 +449,11 @@ void GLRenderManager::Finish() {
frameData.pull_condVar.notify_all();
curFrame_++;
if (curFrame_ >= MAX_INFLIGHT_FRAMES)
if (newInflightFrames_ != -1) {
inflightFrames_ = newInflightFrames_;
newInflightFrames_ = -1;
}
if (curFrame_ >= inflightFrames_)
curFrame_ = 0;
insideFrame_ = false;

View File

@ -862,6 +862,10 @@ public:
enum { MAX_INFLIGHT_FRAMES = 3 };
void UseInflightFrames(bool use) {
newInflightFrames_ = use ? MAX_INFLIGHT_FRAMES : 1;
}
int GetCurFrame() const {
return curFrame_;
}
@ -988,6 +992,9 @@ private:
std::function<void(int)> swapIntervalFunction_;
GLBufferStrategy bufferStrategy_ = GLBufferStrategy::SUBDATA;
int inflightFrames_ = MAX_INFLIGHT_FRAMES;
int newInflightFrames_ = -1;
int swapInterval_ = 0;
bool swapIntervalChanged_ = true;

View File

@ -914,6 +914,10 @@ void VulkanRenderManager::Finish() {
frameData.pull_condVar.notify_all();
}
vulkan_->EndFrame();
if (newInflightFrames_ != -1) {
vulkan_->UpdateInflightFrames(newInflightFrames_);
newInflightFrames_ = -1;
}
insideFrame_ = false;
}

View File

@ -240,6 +240,10 @@ public:
splitSubmit_ = split;
}
void UseInflightFrames(bool use) {
newInflightFrames_ = use ? VulkanContext::MAX_INFLIGHT_FRAMES : 1;
}
VulkanContext *GetVulkanContext() {
return vulkan_;
}
@ -302,6 +306,7 @@ private:
};
FrameData frameData_[VulkanContext::MAX_INFLIGHT_FRAMES];
int newInflightFrames_ = -1;
// Submission time state
int curWidth_ = -1;