libretro/ppsspp
1
0
Fork 0
mirror of https://github.com/libretro/ppsspp.git synced 2025-02-16 15:08:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use ONE/ZERO in place of CONSTANT_ALPHA if okay.

Browse Source
This commit is contained in:
Unknown W. Brackets 2015-02-23 09:58:46 -08:00
parent 3ff51588f7
commit b5126f7236
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
GPU/GLES/StateMapping.cpp
View File

@ -368,7 +368,7 @@ void TransformDrawEngine::ApplyBlendState() {
blendFuncB = GE_DSTBLEND_FIXB; blendFuncB = GE_DSTBLEND_FIXB;
float constantAlpha = 1.0f; float constantAlpha = 1.0f;
bool needsConstantAlpha = false; GLenum constantAlphaGL = GL_ONE;
if (gstate.isStencilTestEnabled() && replaceAlphaWithStencil == REPLACE_ALPHA_NO) { if (gstate.isStencilTestEnabled() && replaceAlphaWithStencil == REPLACE_ALPHA_NO) {
switch (ReplaceAlphaWithStencilType()) { switch (ReplaceAlphaWithStencilType()) {
case STENCIL_VALUE_UNIFORM: case STENCIL_VALUE_UNIFORM:
@ -388,7 +388,13 @@ void TransformDrawEngine::ApplyBlendState() {
default: default:
break; break;
} }
needsConstantAlpha = constantAlpha < 1.0f;
// Otherwise it will stay GL_ONE.
if (constantAlpha <= 0.0f) {
constantAlphaGL = GL_ZERO;
} else if (constantAlpha < 1.0f) {
constantAlphaGL = GL_CONSTANT_ALPHA;
}
} }
// Shortcut by using GL_ONE where possible, no need to set blendcolor // Shortcut by using GL_ONE where possible, no need to set blendcolor
@ -415,7 +421,7 @@ void TransformDrawEngine::ApplyBlendState() {
glstate.blendColor.set(blendColor); glstate.blendColor.set(blendColor);
}; };
auto defaultBlendColor = [&]() { auto defaultBlendColor = [&]() {
if (needsConstantAlpha) { if (constantAlphaGL == GL_CONSTANT_ALPHA) {
const float blendColor[4] = {1.0f, 1.0f, 1.0f, constantAlpha}; const float blendColor[4] = {1.0f, 1.0f, 1.0f, constantAlpha};
glstate.blendColor.set(blendColor); glstate.blendColor.set(blendColor);
} }
@ -531,21 +537,17 @@ void TransformDrawEngine::ApplyBlendState() {
break; break;
case STENCIL_VALUE_UNIFORM: case STENCIL_VALUE_UNIFORM:
// This won't give a correct value (it multiplies) but it may be better than random values. // This won't give a correct value (it multiplies) but it may be better than random values.
if (needsConstantAlpha) { glstate.blendFuncSeparate.set(glBlendFuncA, glBlendFuncB, constantAlphaGL, GL_ZERO);
glstate.blendFuncSeparate.set(glBlendFuncA, glBlendFuncB, GL_CONSTANT_ALPHA, GL_ZERO);
} else {
glstate.blendFuncSeparate.set(glBlendFuncA, glBlendFuncB, GL_ONE, GL_ZERO);
}
break; break;
case STENCIL_VALUE_INCR_4: case STENCIL_VALUE_INCR_4:
case STENCIL_VALUE_INCR_8: case STENCIL_VALUE_INCR_8:
// This won't give a correct value always, but it will try to increase at least. // This won't give a correct value always, but it will try to increase at least.
glstate.blendFuncSeparate.set(glBlendFuncA, glBlendFuncB, GL_CONSTANT_ALPHA, GL_ONE); glstate.blendFuncSeparate.set(glBlendFuncA, glBlendFuncB, constantAlphaGL, GL_ONE);
break; break;
case STENCIL_VALUE_DECR_4: case STENCIL_VALUE_DECR_4:
case STENCIL_VALUE_DECR_8: case STENCIL_VALUE_DECR_8:
// This won't give a correct value always, but it will try to decrease at least. // This won't give a correct value always, but it will try to decrease at least.
glstate.blendFuncSeparate.set(glBlendFuncA, glBlendFuncB, GL_CONSTANT_ALPHA, GL_ONE); glstate.blendFuncSeparate.set(glBlendFuncA, glBlendFuncB, constantAlphaGL, GL_ONE);
alphaEq = GL_FUNC_SUBTRACT; alphaEq = GL_FUNC_SUBTRACT;
break; break;
case STENCIL_VALUE_INVERT: case STENCIL_VALUE_INVERT: