libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-01-23 11:04:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

A typical example why MKID is dangerous: Kyra uses it incorrectly, thus savegames are not interchangable between BE and LE systems. Fixing this, by breaking all LE savegames (enabling a compatibility mode, if desired, is easy)

Browse Source 
svn-id: r20866
This commit is contained in:
Max Horn 2006-02-25 02:35:45 +00:00
parent ee0f0a1f13
commit 075dc8a538
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engines/kyra/saveload.cpp
View File

@ -41,7 +41,11 @@ void KyraEngine::loadGame(const char *fileName) {
}
uint32 type = in->readUint32BE();
if (type != MKID('KYRA')) {
// FIXME: The kyra savegame code used to be endian unsafe. Uncomment the
// following line to graciously handle old savegames from LE machines.
// if (type != MKID_BE('KYRA') && type != MKID_BE('ARYK')) {
if (type != MKID_BE('KYRA')) {
warning("No Kyrandia 1 savefile header");
delete in;
return;
@ -233,7 +237,7 @@ void KyraEngine::saveGame(const char *fileName, const char *saveName) {
}
// Savegame version
out->writeUint32BE(MKID('KYRA'));
out->writeUint32BE(MKID_BE('KYRA'));
out->writeUint32BE(CURRENT_VERSION);
out->write(saveName, 31);
out->writeUint32BE(_features);