From 0854dbd68c427ba9b02cc18dd073deac35fed860 Mon Sep 17 00:00:00 2001 From: Eugene Sandulenko Date: Tue, 5 Jul 2016 19:23:04 +0200 Subject: [PATCH] Revert "GRAPHICS: Fix GUI transparency. As pointed by blitter on IRC" This reverts commit 1d3d6c869240ad076631576be081cfadfef34865. As it was pointed by wjp, this fully ignores the alphamask. --- graphics/VectorRendererSpec.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/graphics/VectorRendererSpec.cpp b/graphics/VectorRendererSpec.cpp index 48ea7dc68c0..258d935440b 100644 --- a/graphics/VectorRendererSpec.cpp +++ b/graphics/VectorRendererSpec.cpp @@ -603,8 +603,9 @@ applyScreenShading(GUI::ThemeEngine::ShadingStyle shadingStyle) { if (shadingStyle == GUI::ThemeEngine::kShadingDim) { + // TODO: Check how this interacts with kFeatureOverlaySupportsAlpha for (int i = 0; i < pixels; ++i) { - *ptr = (((*ptr | _alphaMask) & colorMask) >> 1); + *ptr = ((*ptr & colorMask) >> 1) | _alphaMask; ++ptr; }