libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-01-09 03:10:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

TINYGL: Fix y coordinate tracking when drawing triangles.

Browse Source 
Increment y inside the loop, not outside.
Set y to the topmost vertex y coordinate, which depends on which half of
the triangle is being drawn.
Should have been part of:
  commit 3c2689a65f
  TINYGL: Optimise scissorPixel.

This does not (should not) fix any visible regression, as pixel scissor is
only (?) used when dirty rectangle mecanism is enabled (and it is disabled).
This commit is contained in:
Vincent Pelletier 2016-07-25 04:18:05 +02:00
parent d4a50ba13f
commit 18342118dc
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
graphics/tinygl/ztriangle.cpp
View File

@ -286,6 +286,7 @@ void FrameBuffer::fillTriangle(ZBufferPoint *p0, ZBufferPoint *p1, ZBufferPoint
}
for (part = 0; part < 2; part++) {
int y;
if (part == 0) {
if (fz0 > 0) {
update_left = 1;
@ -303,6 +304,7 @@ void FrameBuffer::fillTriangle(ZBufferPoint *p0, ZBufferPoint *p1, ZBufferPoint
pr2 = p2;
}
nb_lines = p1->y - p0->y;
y = p0->y;
} else {
// second part
if (fz0 > 0) {
@ -317,6 +319,7 @@ void FrameBuffer::fillTriangle(ZBufferPoint *p0, ZBufferPoint *p1, ZBufferPoint
l2 = p2;
}
nb_lines = p2->y - p1->y + 1;
y = pr1->y;
}
// compute the values for the left edge
@ -391,7 +394,6 @@ void FrameBuffer::fillTriangle(ZBufferPoint *p0, ZBufferPoint *p1, ZBufferPoint
x2 = pr1->x << 16;
}
int y = p1->y;
// we draw all the scan line of the part
while (nb_lines > 0) {
nb_lines--;
@ -654,8 +656,8 @@ void FrameBuffer::fillTriangle(ZBufferPoint *p0, ZBufferPoint *p1, ZBufferPoint
if (kDrawLogic == DRAW_SHADOW || kDrawLogic == DRAW_SHADOW_MASK)
pm1 = pm1 + xsize;
y++;
}
y++;
}
}