libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-03-03 00:35:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

COMMON: Flag some Path functions as WARN_UNUSED_RESULT

Browse Source 
This would have caught the recent Hopkins regression. It also warns
about a few other things at the moment, so that has to be looked into at
some point.
This commit is contained in:
Torbjörn Andersson 2024-02-09 18:52:45 +01:00
parent 0ad2ebc9c4
commit 18ff31bc92
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
common/path.h
View File

@ -397,19 +397,19 @@ public:
* Returns this path with the given path appended (out-of-place).
* Does not automatically add a directory separator.
*/
Path append(const Path &x) const {
WARN_UNUSED_RESULT Path append(const Path &x) const {
Path temp(*this);
temp.appendInPlace(x);
return temp;
}
/** @overload */
Path append(const String &str, char separator = '/') const {
WARN_UNUSED_RESULT Path append(const String &str, char separator = '/') const {
return append(str.c_str(), separator);
}
/** @overload */
Path append(const char *str, char separator = '/') const {
WARN_UNUSED_RESULT Path append(const char *str, char separator = '/') const {
Path temp(*this);
temp.appendInPlace(str, separator);
return temp;
@ -419,10 +419,10 @@ public:
* Appends exactly one component, without any separators
* and prepends a separator if necessarry
*/
Path appendComponent(const char *str) const;
WARN_UNUSED_RESULT Path appendComponent(const char *str) const;
/** @overload */
Path appendComponent(const String &x) const {
WARN_UNUSED_RESULT Path appendComponent(const String &x) const {
return appendComponent(x.c_str());
}
@ -444,19 +444,19 @@ public:
* Returns this path joined with the given path (out-of-place).
* Automatically adds a directory separator.
*/
Path join(const Path &x) const {
WARN_UNUSED_RESULT Path join(const Path &x) const {
Path temp(*this);
temp.joinInPlace(x);
return temp;
}
/** @overload */
Path join(const String &str, char separator = '/') const {
WARN_UNUSED_RESULT Path join(const String &str, char separator = '/') const {
return join(str.c_str(), separator);
}
/** @overload */
Path join(const char *str, char separator = '/') const {
WARN_UNUSED_RESULT Path join(const char *str, char separator = '/') const {
Path temp(*this);
temp.joinInPlace(str, separator);
return temp;