libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-03-07 02:39:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Removed the test for non-existing demo cutscenes: param[0] is an offset

Browse Source 
into the chunk of memory handled by the memory manager, not a well-defined
value. Also, it introduced a theoretical memory leak as fnPlaySequence()
wouldn't get to clean up after itself.

The correct place for this check is probably in MoviePlayer::play(), where
you can test the name of the cutscene. On the other hand, the original demo
will gladly play eye.smk if there is one, so why shouldn't we?

svn-id: r13139
This commit is contained in:
Torbjörn Andersson 2004-03-02 07:02:31 +00:00
parent ca85e8d51d
commit 1bdcc3e5ef
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sword2/anims.cpp
View File

@ -621,10 +621,6 @@ int32 Logic::fnPlaySequence(int32 *params) {
// params: 0 pointer to null-terminated ascii filename
// 1 number of frames in the sequence, used for PSX.
// Only two sequences exist in demo
if ((_vm->_features & GF_DEMO) && params[0] != 3626 && params[0] != 3879846)
return IR_CONT;
char filename[30];
uint32 rv;
MovieTextObject *sequenceSpeechArray[MAX_SEQUENCE_TEXT_LINES + 1];