libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-04-03 15:21:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

SCUMM: cleanup b4185bdf

Browse Source 
Extend change to the versions to which it applies and update comment.
This commit is contained in:
athrxx 2022-08-15 18:12:42 +02:00
parent 683e1ca8f1
commit 221f9c955f
1 changed files with 5 additions and 8 deletions

13
engines/scumm/charset.cpp

@ -457,14 +457,11 @@ int CharsetRendererClassic::getCharWidth(uint16 chr) const {
int CharsetRenderer::getStringWidth(int arg, const byte *text) {
int pos = 0;
// I have confirmed from disasm that LOOM EGA and FM-TOWNS (EN/JP) do not add 1 to the width
// while LOOM VGA Talkie and MONKEY1 EGA do. So that seems to have been introduced with version 4.
// TODO: Check other v1-3 games. Loom IS the only game in that version range that has charset mask
// (overlaying) text display, the others are limited to top screen and verb screen. So it might not
// be that relevant....
int width = 1;
if (_vm->_game.id == GID_FT || (_vm->_game.id == GID_LOOM && _vm->_game.version < 4))
width = 0;
// I have confirmed from disasm that neither LOOM EGA and FM-TOWNS (EN/JP) nor any other games withing the
// v0-v3 version range add 1 to the width. There isn't even a getStringWidth method. And the v0-2 games don't
// even support text rendering over strip borders. However, LOOM VGA Talkie and MONKEY1 EGA do have the
// getStringWidth method and they do add 1 to the width. So that seems to have been introduced with version 4.
int width = (_vm->_game.version < 4 || _vm->_game.id == GID_FT) ? 0 : 1;
int chr;
int oldID = getCurID();