libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-03-03 16:58:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

SCUMM: Backport a small enhancement from the Japanese Indy3 FM-TOWNS release

Browse Source 
One of the tunnels in the catacombs has no object description at all, in some
Indy3 releases. This was fixed in the Japanese FM-TOWNS release, but not in
the English FM-TOWNS release (this, among other differences between the two
releases, makes me think that the Japanese release actually benefited from
some late fixes).

This is a very minor issue, but since it's trivial to fix it, and since LEC
decided that it was worth a bugfix themselves, let's do it too.
This commit is contained in:
Donovan Watteau 2024-08-31 09:26:30 +02:00
parent 228190ad71
commit 28891948d6
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
engines/scumm/string.cpp
View File

@ -1688,7 +1688,21 @@ int ScummEngine::convertNameMessage(byte *dst, int dstSize, int var) {
num = readVar(var);
if (num) {
const byte *ptr = getObjOrActorName(num);
if (ptr) {
// WORKAROUND: Some releases of Indy3 miss the description of one of the
// tunnels in the catacombs. For example, it's there in the Macintosh or
// in the Japanese FM-TOWNS release, but missing from the English FM-TOWNS
// or the DOS VGA releases. This is a minor issue, but since LEC themselves
// fixed this for some releases, we can do the same... just copy the object
// description from the other tunnel, if the former is empty.
if (_game.id == GID_INDY3 && _roomResource == 59 && num == 725 && *ptr == 0 &&
whereIsObject(724) != WIO_NOT_FOUND && enhancementEnabled(kEnhMinorBugFixes)) {
const byte *fallbackObjPtr = getObjOrActorName(724);
if (fallbackObjPtr)
ptr = fallbackObjPtr;
}
int increment = convertMessageToString(ptr, dst, dstSize);
// Save the final consonant (jongsung) of the last Korean character
// Used by Korean fan translated games (monkey1, monkey2)