libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-01-07 10:21:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

GUI: Do not show empty hole in Graphics tab when Filtering is not supported by the backend

Browse Source
This commit is contained in:
Eugene Sandulenko 2022-10-06 18:49:26 +02:00
parent 4237575f65
commit 3e7ec681d1
1 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
gui/options.cpp
View File

@ -395,9 +395,6 @@ void OptionsDialog::build() {
_filteringCheckbox->setState(ConfMan.getBool("filtering", _domain));
if (ConfMan.isKeyTemporary("filtering"))
_filteringCheckbox->setOverride(true);
} else {
_filteringCheckbox->setState(false);
_filteringCheckbox->setEnabled(false);
}
// Aspect ratio setting
@ -574,11 +571,12 @@ void OptionsDialog::apply() {
// Graphic options
if (_fullscreenCheckbox) {
if (_enableGraphicSettings) {
if (ConfMan.getBool("filtering", _domain) != _filteringCheckbox->getState()) {
graphicsModeChanged = true;
ConfMan.setBool("filtering", _filteringCheckbox->getState(), _domain);
_filteringCheckbox->setOverride(false);
}
if (g_system->hasFeature(OSystem::kFeatureFilteringMode))
if (ConfMan.getBool("filtering", _domain) != _filteringCheckbox->getState()) {
graphicsModeChanged = true;
ConfMan.setBool("filtering", _filteringCheckbox->getState(), _domain);
_filteringCheckbox->setOverride(false);
}
if (ConfMan.getBool("fullscreen", _domain) != _fullscreenCheckbox->getState()) {
graphicsModeChanged = true;
ConfMan.setBool("fullscreen", _fullscreenCheckbox->getState(), _domain);
@ -1205,8 +1203,6 @@ void OptionsDialog::setGraphicSettingsState(bool enabled) {
if (g_system->hasFeature(OSystem::kFeatureFilteringMode))
_filteringCheckbox->setEnabled(enabled);
else
_filteringCheckbox->setEnabled(false);
if (g_system->hasFeature(OSystem::kFeatureFullscreenMode))
_fullscreenCheckbox->setEnabled(enabled);
@ -1579,7 +1575,8 @@ void OptionsDialog::addGraphicControls(GuiObject *boss, const Common::String &pr
}
// Filtering checkbox
_filteringCheckbox = new CheckboxWidget(boss, prefix + "grFilteringCheckbox", _("Filter graphics"), _("Use linear filtering when scaling graphics"));
if (g_system->hasFeature(OSystem::kFeatureFilteringMode))
_filteringCheckbox = new CheckboxWidget(boss, prefix + "grFilteringCheckbox", _("Filter graphics"), _("Use linear filtering when scaling graphics"));
// Aspect ratio checkbox
_aspectCheckbox = new CheckboxWidget(boss, prefix + "grAspectCheckbox", _("Aspect ratio correction"), _("Correct aspect ratio for games"));
@ -1923,8 +1920,7 @@ void OptionsDialog::setupGraphicsTab() {
_fullscreenCheckbox->setVisible(true);
if (g_system->hasFeature(OSystem::kFeatureFilteringMode))
_filteringCheckbox->setVisible(true);
else
_filteringCheckbox->setVisible(false);
_aspectCheckbox->setVisible(true);
_renderModePopUpDesc->setVisible(true);
_renderModePopUp->setVisible(true);