From 4172414e358099bb937044629d6d9c794637629c Mon Sep 17 00:00:00 2001 From: Max Horn Date: Wed, 23 Mar 2011 11:26:41 +0100 Subject: [PATCH] COMMON: Remove TODO from struct Event I moved this TODO to the Wiki TODO page and extended it there. Yet while I originally wrote it, I now think that we are probably best off keeping things as they are. --- common/events.h | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/common/events.h b/common/events.h index f9ebce7d64e..120d7d9dea0 100644 --- a/common/events.h +++ b/common/events.h @@ -81,30 +81,6 @@ enum EventType { /** * Data structure for an event. A pointer to an instance of Event * can be passed to pollEvent. - * @todo Rework/document this structure. It should be made 100% clear which - * field is valid for which event type. - * Implementation wise, we might want to use the classic - * union-of-structs trick. It goes roughly like this: - * struct BasicEvent { - * EventType type; - * }; - * struct MouseMovedEvent : BasicEvent { - * Common::Point pos; - * }; - * struct MouseButtonEvent : MouseMovedEvent { - * int button; - * }; - * struct KeyEvent : BasicEvent { - * ... - * }; - * ... - * union Event { - * EventType type; - * MouseMovedEvent mouse; - * MouseButtonEvent button; - * KeyEvent key; - * ... - * }; */ struct Event { /** The type of the event. */