libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2024-12-13 04:28:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

TWP: increase maximum "give" distance

Browse Source 
Commit 7dd6c4ba62 (TWP: Fix give minimum distance, 2024-03-07)
increased the maximum distance for allowing objects to be given from 15
to 30. This works fine for most of the game, but there is at least one
instance where 30 prevents a crucial transaction: Ransome exchanging
wallets with Willie. This is visible in the following debug log:

  Give 'ransomeWallet' to 'willie'
  exec(currentActor,9,ransomeWallet,willie)
  noun1.inInventory: YES and noun1.touchable: YES nowalk: NO
  walk to obj willie: (1533.000000,91.000000)
  walk to obj ransome: 1503.000000,91.000000, 1
  Give 'ransomeWallet' to 'willie'
  actorArrived
  actor arrived with facing 1
  call actorArrived callback
  actorArrived: exec sentence
  actorArrived: noun2 min_dist: 30.265491 > 30.000000 ?
  translate(@30087): Willie
  sayline: ransome, @24882
  talking ransome audio stopped
  Give 'ransomeWallet' to 'willie'
  talking ransome: @24882
  Load lip RANSOME_24882.lip
  Lip RANSOME_24882.lip loaded
  loadActorSpeech RANSOME_24882.ogg
  talking ransome audio id: 250087, dur: 1821
  sayLine 'He is too far away.'

Here we can see Ransome moving within 30.27 distance units from Willie
without being obstructed by anything, however this is not close enough
for "give" to work. Let's bump MIN_GIVE_DIST to 35, which fixes the
issue.
This commit is contained in:
Apollon Oikonomopoulos 2024-07-22 14:05:04 +03:00 committed by scemino
parent e9f7121d7a
commit 42df06e4f8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engines/twp/object.cpp
View File

@ -27,7 +27,7 @@
#include "twp/squtil.h"
#define MIN_TALK_DIST 60
#define MIN_GIVE_DIST 30
#define MIN_GIVE_DIST 35
#define MIN_USE_DIST 15
namespace Twp {