libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-02-19 10:41:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ULTIMA8: Add comment about iteration order

Browse Source 
This function looks tempting to "optimize", by changing the order, so add a
warning for new adventurers.
This commit is contained in:
Matthew Duggan 2021-05-08 09:46:04 +09:00
parent cbb3346210
commit 531ed6865b
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
engines/ultima/ultima8/world/current_map.cpp
View File

@ -572,6 +572,15 @@ void CurrentMap::areaSearch(UCList *itemlist, const uint8 *loopscript,
int maxy = ((y + range) / _mapChunkSize) + 1;
clipMapChunks(minx, maxx, miny, maxy);
//
// NOTE: Iteration order of chunks here is important for
// usecode compatibility!
//
// eg, No Remorse Mission 2 has a camera which searches for
// trigger with qlo = 5, but there are 2 of those on the map.
// We need to return in the correct order or it triggers
// the wrong one and breaks the game.
//
for (int cy = miny; cy <= maxy; cy++) {
for (int cx = minx; cx <= maxx; cx++) {
item_list::const_iterator iter;