libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2024-12-14 05:38:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Added FIXME comment about 'static' abuse in imuse_part.cpp

Browse Source 
svn-id: r24327
This commit is contained in:
Max Horn 2006-10-15 01:51:02 +00:00
parent 65e923480e
commit 548cb2fbad
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
engines/scumm/imuse/imuse_part.cpp
View File

@ -230,6 +230,13 @@ void Part::noteOn(byte note, byte velocity) {
mc = _player->getMidiDriver()->getPercussionChannel();
if (!mc)
return;
// FIXME: The following is evil, EVIL!!! Either prev_vol_eff is
// actually meant to be a member of the Part class (i.e. each
// instance of Part keeps a separate copy of it); or it really
// is supposed to be shared by all Part instances -- but then it
// should be implemented as a class static var. As it is, using
// a function level static var in most cases is arcane and evil.
static byte prev_vol_eff = 128;
if (_vol_eff != prev_vol_eff){
mc->volume(_vol_eff);