libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-02-09 04:16:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

SCI: using only channels 1-8 on GM devices

Browse Source 
There are many situations that GM sounds worse than MT, even for games
that were written for GM.
I think this is related to this.
And, there is a note in midi.cpp:
// NOTE: SSCI uses channels 1 through 8 for General MIDI as well, in the drivers I checked

Also, issue #6686 reports that using the "higher" channels causes
problem on a real SC-55.

This change solves at least: #6686, #9735 and #10297
This commit is contained in:
Zvika Haramaty 2020-02-17 02:03:23 +02:00 committed by Filippos Karapetis
parent 887db8a821
commit 5ab4185257
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engines/sci/sound/drivers/midi.cpp
View File

@ -465,15 +465,11 @@ void MidiPlayer_Midi::send(uint32 b) {
// We return 1 for mt32, because if we remap channels to 0 for mt32, those won't get played at all
// NOTE: SSCI uses channels 1 through 8 for General MIDI as well, in the drivers I checked
int MidiPlayer_Midi::getFirstChannel() const {
if (_mt32Type != kMt32TypeNone)
return 1;
return 0;
return 1;
}
int MidiPlayer_Midi::getLastChannel() const {
if (_mt32Type != kMt32TypeNone)
return 8;
return 15;
return 8;
}
void MidiPlayer_Midi::setVolume(byte volume) {