libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2024-12-14 05:38:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

GUI: Fix dangling pointer when _headerEntryList was reallocated

Browse Source 
As we know the size of the array in advance we can preallocate it.
This commit is contained in:
Le Philousophe 2022-06-10 07:49:29 +02:00
parent 148cfc1b70
commit 6a3e97d863
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gui/widgets/grid.cpp
View File

@ -470,6 +470,9 @@ void GridWidget::sortGroups() {
// No filter -> display everything with group headers
Common::sort(_groupHeaders.begin(), _groupHeaders.end());
// Avoid reallocation during iteration: that would invalidate our _sortedEntryList items
_headerEntryList.reserve(_groupHeaders.size());
for (uint i = 0; i != _groupHeaders.size(); ++i) {
Common::U32String header = _groupHeaders[i];
Common::U32String displayedHeader;