From 7714e09382285ea4f12a0682444b30abedbba521 Mon Sep 17 00:00:00 2001 From: Scott Percival Date: Fri, 18 Nov 2022 11:20:17 +0800 Subject: [PATCH] DIRECTOR: LINGO: Remove duplicate insert in b_addProp Previously, all property list inserts would happen twice, causing widespread mayhem. Property lists are allowed to have duplicate keys, which may have disguised the impact of this bug. Fixes lots of voice clips playing twice in DEVO Presents: Adventures of the Smart Patrol. --- engines/director/lingo/lingo-builtins.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/engines/director/lingo/lingo-builtins.cpp b/engines/director/lingo/lingo-builtins.cpp index c4ce3ed0e33..d9ea34d27ea 100644 --- a/engines/director/lingo/lingo-builtins.cpp +++ b/engines/director/lingo/lingo-builtins.cpp @@ -591,7 +591,6 @@ void LB::b_addProp(int nargs) { TYPECHECK(list, PARRAY); PCell cell = PCell(prop, value); - list.u.parr->arr.push_back(cell); if (list.u.parr->_sorted) { if (list.u.parr->arr.empty())