libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2024-12-22 09:49:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Changed the parameter passed to isprint() to be unsigned, according to MSDN (thanks wjp)

Browse Source 
svn-id: r39370
This commit is contained in:
Filippos Karapetis 2009-03-13 10:36:57 +00:00
parent 0916523763
commit 7854a01f14
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
engines/sci/engine/kstring.cpp
View File

@ -414,11 +414,12 @@ static int is_print_str(char *str) {
if (len == 0) return 1;
while (*str) {
// We're ANDing the string with 0xFF to prevent a situation
// where MSVC could sometimes falsely parse the character as
// multibyte/Unicode, thereby overflowing an assertion inside
// isprint(). This occurs after the intro of LSL5, for example.
if (isprint((*str & 0xFF))) printable++;
// The parameter passed to isprint() needs to be in the range
// 0 to 0xFF or EOF, according to MSDN, therefore we cast it
// to an unsigned char. Values outside this range (in this
// case, negative values) yield unpredictable results. Refer to:
// http://msdn.microsoft.com/en-us/library/ewx8s4kw.aspx
if (isprint((unsigned char)*str)) printable++;
str++;
}