libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-01-24 11:36:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

AUDIO: Properly handle AdLibPercussionChannel::noteOff.

Browse Source
This commit is contained in:
Johannes Schickel 2012-09-30 21:27:55 +02:00
parent e5c41cbf9a
commit 78e8b9dd59
1 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
audio/softsynth/adlib.cpp
View File

@ -839,18 +839,16 @@ void AdLibPercussionChannel::init(MidiDriver_ADLIB *owner, byte channel) {
}
void AdLibPercussionChannel::noteOff(byte note) {
// Jamieson630: Unless I run into a specific instrument that
// may require a key off, I'm going to ignore this message.
// The rationale is that a percussion instrument should
// fade out of its own accord, and the AdLib instrument
// definitions used should follow this rule. Since
// percussion voices are allocated at the lowest priority
// anyway, we know that "hanging" percussion sounds will
// not prevent later musical instruments (or even other
// percussion sounds) from playing.
/*
if (_customInstruments[note]) {
note = _notes[note];
}
// This used to ignore note off events, since the builtin percussion
// instrument data has a duration value, which causes the percussion notes
// to stop automatically. This is not the case for (Groovie's) custom
// percussion instruments though. Also the OPL3 driver of Sam&Max actually
// does not handle the duration value, so we need it there too.
_owner->partKeyOff(this, note);
*/
}
void AdLibPercussionChannel::noteOn(byte note, byte velocity) {