libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2024-12-14 21:59:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

SDL: Switch to full screen updates when the OSD is transparent

Browse Source 
Previous releases also did full screen updates for transparent OSD messages.
There should be no performance regression with that regard.

Computing smaller update rects is non trivial, but should be looked into if
performance is an issue for OSD icons.

Fixes #9598
This commit is contained in:
Bastien Bouclet 2016-10-03 07:16:22 +02:00
parent 3f6ca96c5b
commit 7941e5d530
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
backends/graphics/surfacesdl/surfacesdl-graphics.cpp
View File

@ -2176,9 +2176,8 @@ void SurfaceSdlGraphicsManager::displayActivityIconOnOSD(const Graphics::Surface
Common::StackLock lock(_graphicsMutex); // Lock the mutex until this function ends
if (_osdIconSurface && !icon) {
// Add a dirty rect to clear the icon on the next update
SDL_Rect dstRect = getOSDIconRect();
addDirtyRect(dstRect.x, dstRect.y, dstRect.w, dstRect.h, true);
// Force a redraw to clear the icon on the next update
_forceFull = true;
}
if (_osdIconSurface) {
@ -2249,6 +2248,7 @@ void SurfaceSdlGraphicsManager::updateOSD() {
_osdMessageAlpha = startAlpha + diff * (SDL_ALPHA_TRANSPARENT - startAlpha) / kOSDFadeOutDuration;
}
SDL_SetAlpha(_osdMessageSurface, SDL_RLEACCEL | SDL_SRCCOLORKEY | SDL_SRCALPHA, _osdMessageAlpha);
_forceFull = true;
}
if (_osdMessageAlpha == SDL_ALPHA_TRANSPARENT) {
@ -2256,14 +2256,9 @@ void SurfaceSdlGraphicsManager::updateOSD() {
}
}
if (_osdMessageSurface) {
SDL_Rect dstRect = getOSDMessageRect();
addDirtyRect(dstRect.x, dstRect.y, dstRect.w, dstRect.h, true);
}
if (_osdIconSurface) {
SDL_Rect dstRect = getOSDIconRect();
addDirtyRect(dstRect.x, dstRect.y, dstRect.w, dstRect.h, true);
// Redraw the area below the icon for the transparent blit to give correct results.
_forceFull = true;
}
}