libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-01-09 19:32:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

SCUMM: Clarify workaround for Venice music in Indy 3 FMTOWNS

Browse Source
This commit is contained in:
Adrian Frühwirth 2018-07-02 14:39:23 +02:00
parent cf52951915
commit 7df014ea6d
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
engines/scumm/players/player_towns.cpp
View File

@ -255,10 +255,16 @@ void Player_Towns_v1::startSound(int sound) {
velocity = velocity ? velocity >> 2 : ptr[14] >> 1;
uint16 len = READ_LE_UINT16(ptr) + 2;
playPcmTrack(sound, ptr + 6, velocity, 64, note ? note : (len > 50 ? ptr[50] : 60), READ_LE_UINT16(ptr + 10));
// WORKAROUND for bug #1873 INDY3 FMTOWNS: Music in Venice is distorted
// The resource for sound 40 accidently sets the sound type to 255 instead of 1.
} else if (type == 1 || (_vm->_game.id == GID_INDY3 && sound == 40)) {
// WORKAROUND: Indy 3 FMTOWNS: No/distorted music in Venice
// The Venice music does not exist as CD audio and the original doesn't feature music
// in this scene. It does, however, exist as Euphony track albeit with an odd sound
// type (255 instead of 1).
// It doesn't sound great but we'll enable it to have music at all in this scene.
// See Trac#1873 and Trac#10561.
//
// TODO: Check if playback of this can be improved somehow (maybe there's something else
// off with the data for which we can add a workaround?).
playEuphonyTrack(sound, ptr + 6);
} else if (type == 2) {