libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-01-31 07:53:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

OPENGL: Use the correct index when attribute is added after link

Browse Source
This commit is contained in:
Le Philousophe 2022-10-09 18:30:29 +02:00
parent 3c8b58af95
commit 884c3aa795
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
graphics/opengl/shader.cpp
View File

@ -415,6 +415,8 @@ void Shader::freeBuffer(GLuint vbo) {
}
bool Shader::addAttribute(const char *attrib) {
// Once we are linked we can't rebind the attribute so we have to deal with its place defined by OpenGL
// As we store attribute at its OpenGL index, we will end up with empty attributes in the middle
uint32 i;
for (i = 0; i < _attributes.size(); ++i)
if (_attributes[i]._name.equals(attrib))
@ -422,11 +424,19 @@ bool Shader::addAttribute(const char *attrib) {
GLint result = -1;
GL_ASSIGN(result, glGetAttribLocation(*_shaderNo, attrib));
if (result == -1)
if (result < 0)
return false;
GL_CALL(glBindAttribLocation(*_shaderNo, i, attrib));
_attributes.push_back(VertexAttrib(i, attrib));
// Make sure we can store our new attribute
if (_attributes.size() <= (uint)result) {
for(; i < (uint)result; i++) {
_attributes.push_back(VertexAttrib(i, ""));
}
_attributes.push_back(VertexAttrib(result, attrib));
}
_attributes[result] = VertexAttrib(result, attrib);
return true;
}