libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-02-03 09:23:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

SCI: Fix uninitialized variable warning in g++.

Browse Source 
Thanks to clone2727 for suggestion to initialize the default new plane
priority to 0xFFFF, which means that the plane should be invisible. I added a
FIXME there though. So please re check this change. In case that is fine just
remove the FIXME, in case some other default value should be chosen, please
change the value and also remove the FIXME.

svn-id: r51561
This commit is contained in:
Johannes Schickel 2010-08-01 01:00:30 +00:00
parent 57ad040846
commit 8851c2016f
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
engines/sci/graphics/frameout.cpp
View File

@ -68,6 +68,9 @@ void GfxFrameout::kernelAddPlane(reg_t object) {
newPlane.object = object;
newPlane.pictureId = 0xFFFF;
// TODO/FIXME: Check whether we should really default initialize the
// priority to 0xFFFF here.
newPlane.priority = 0xFFFF;
newPlane.lastPriority = 0xFFFF; // hidden
_planes.push_back(newPlane);
@ -125,6 +128,7 @@ void GfxFrameout::addPlanePicture(reg_t object, GuiResourceId pictureId, uint16
newPicture.pictureId = pictureId;
newPicture.picture = new GfxPicture(_resMan, _coordAdjuster, 0, _screen, _palette, pictureId, false);
newPicture.startX = startX;
newPicture.pictureCels = 0;
_planePictures.push_back(newPicture);
}