From 8b8f1548919b39458b7a682b8ef67f2d69c9ce02 Mon Sep 17 00:00:00 2001 From: Johannes Schickel Date: Tue, 10 Nov 2009 21:14:48 +0000 Subject: [PATCH] Add some FIXME comments about defining types from stdint.h on our own. svn-id: r45816 --- common/scummsys.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/common/scummsys.h b/common/scummsys.h index 0231aded542..9cd503b7512 100644 --- a/common/scummsys.h +++ b/common/scummsys.h @@ -198,6 +198,9 @@ #define SMALL_SCREEN_DEVICE #endif + // FIXME: It is not the nicest idea to define these types + // on our own, since they should be defined in "stdint.h" + // for compilers with a C99 library. typedef signed char int8_t; typedef signed short int16_t; typedef unsigned char uint8_t; @@ -215,6 +218,19 @@ #define NORETURN __declspec(noreturn) #define PLUGIN_EXPORT __declspec(dllexport) + // FIXME: It is not the nicest idea to define these types + // on our own, since they should be defined in "stdint.h" + // for compilers with a C99 library. Since MSVC does not + // supply any C99 headers, we must define these types + // on owr own, sadly SDL seems to do the same, but they + // define "uint32_t" as "unsigned __int32" and "int32_t" + // as "signed __int32", which leads to compilation errors + // when this file is included before SDL.h. + // We might either switch to the same definitions SDL.h + // uses or clean this up in a different way, it seems + // the only code relying on these types is the MPEG2 + // code, so maybe we can move this a bit more locally + // to the MPEG2 code. typedef signed char int8_t; typedef signed short int16_t; typedef unsigned char uint8_t;