libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2024-12-02 15:16:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

COMMON: Fix memory leak in MidiDriver. PVS-Studio V773

Browse Source
This commit is contained in:
sluicebox 2023-10-30 11:22:10 -07:00
parent fc87406f93
commit 8ba3a70961
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
audio/mididrv.cpp
View File

@ -523,19 +523,19 @@ void MidiDriver_BASE::midiDumpSysEx(const byte *msg, uint16 length) {
void MidiDriver_BASE::midiDumpFinish() {
Common::DumpFile *midiDumpFile = new Common::DumpFile();
midiDumpFile->open("dump.mid");
midiDumpFile->write("MThd\0\0\0\x6\0\x1\0\x2", 12); // standard MIDI file header, with two tracks
midiDumpFile->write("\x1\xf4", 2); // division - 500 ticks per beat, i.e. a quarter note. Each tick is 1ms
midiDumpFile->write("MTrk", 4); // start of first track - doesn't contain real data, it's just common practice to use two tracks
midiDumpFile->writeUint32BE(4); // first track size
midiDumpFile->write("\0\xff\x2f\0", 4); // meta event - end of track
midiDumpFile->write("MTrk", 4); // start of second track
midiDumpFile->writeUint32BE(_midiDumpCache.size() + 4); // track size (+4 because of the 'end of track' event)
midiDumpFile->write(_midiDumpCache.data(), _midiDumpCache.size());
midiDumpFile->write("\0\xff\x2f\0", 4); // meta event - end of track
midiDumpFile->finalize();
midiDumpFile->close();
Common::DumpFile midiDumpFile;
midiDumpFile.open("dump.mid");
midiDumpFile.write("MThd\0\0\0\x6\0\x1\0\x2", 12); // standard MIDI file header, with two tracks
midiDumpFile.write("\x1\xf4", 2); // division - 500 ticks per beat, i.e. a quarter note. Each tick is 1ms
midiDumpFile.write("MTrk", 4); // start of first track - doesn't contain real data, it's just common practice to use two tracks
midiDumpFile.writeUint32BE(4); // first track size
midiDumpFile.write("\0\xff\x2f\0", 4); // meta event - end of track
midiDumpFile.write("MTrk", 4); // start of second track
midiDumpFile.writeUint32BE(_midiDumpCache.size() + 4); // track size (+4 because of the 'end of track' event)
midiDumpFile.write(_midiDumpCache.data(), _midiDumpCache.size());
midiDumpFile.write("\0\xff\x2f\0", 4); // meta event - end of track
midiDumpFile.finalize();
midiDumpFile.close();
const char msg[] = "Ending MIDI dump, created 'dump.mid'";
g_system->displayMessageOnOSD(_(msg)); //TODO: why it doesn't appear?
debug("%s", msg);