libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-02-24 05:01:43 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Updated the list of TODOs

Browse Source 
svn-id: r45768
This commit is contained in:
Robert Špalek 2009-11-08 22:48:27 +00:00
parent ea0b2a8cb8
commit 8edfd6b56c
5 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engines/draci/music.cpp
View File

@ -125,6 +125,8 @@ void MusicPlayer::send(uint32 b) {
if (!_channel[channel]) {
_channel[channel] = (channel == 9) ? _driver->getPercussionChannel() : _driver->allocateChannel();
// If a new channel is allocated during the playback, make sure
// its volume is correctly initialized.
setChannelVolume(channel);
}
@ -232,12 +234,6 @@ void MusicPlayer::syncVolume() {
int volume = ConfMan.getInt("music_volume");
debugC(2, kDraciSoundDebugLevel, "Syncing music volume to %d", volume);
setVolume(volume);
// TODO: doesn't work in the beginning when no music is playing yet.
// It goes through all active channels (= none) and stops. Only after
// actual instruments have played in the channels, this has an effect.
// As a consequence, music is very loud in the beginning until Ctrl-F5
// is pressed for the first time.
}
} // End of namespace Draci

1
engines/draci/screen.cpp
View File

@ -88,7 +88,6 @@ void Screen::interpolatePalettes(const byte *first, const byte *second, uint16 s
_palette[i * 4 + 3] = 0;
}
// TODO: Investigate why this is needed
// Shift the palette two bits to the left to make it brighter
for (int i = start * 4; i < (start + num) * 4; ++i) {
_palette[i] <<= 2;

1
engines/draci/script.cpp
View File

@ -572,6 +572,7 @@ void Script::icoStat(Common::Queue<int> &params) {
}
if (_vm->_mouse->getCursorType() == kNormalCursor) {
// TODO: is this correct?
if (_vm->_game->getLoopStatus() == kStatusInventory) {
_vm->_mouse->cursorOff();
}

2
engines/draci/sprite.cpp
View File

@ -307,8 +307,8 @@ void Text::draw(Surface *surface, bool markDirty, int relX, int relY) const {
_font->drawString(surface, _text, _x + relX, _y + relY, _colour, _spacing, true);
}
// TODO: Handle scaled parameter properly by implementing Text scaling
Common::Rect Text::getRect(const Displacement &displacement) const {
// Texts are never scaled
return Common::Rect(_x + displacement.relX, _y + displacement.relY, _x + displacement.relX + _width, _y + displacement.relY + _height);
}

2
engines/draci/walking.cpp
View File

@ -645,7 +645,7 @@ bool WalkingState::walkOnNextEdge() {
Movement nextAnim = directionForNextPhase();
_lastAnimPhase = _vm->_game->playHeroAnimation(nextAnim);
// TODO: do we need to clear this callback for the animation?
// TODO: do we need to clear the callback for the turning animation?
debugC(2, kDraciWalkingDebugLevel, "Turned for edge %d, starting animation %d with phase %d", _segment, nextAnim, _lastAnimPhase);