libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2024-12-15 06:08:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

AGI: Added a few comments about KQ1

Browse Source 
set.simple gets called when killing the witch + planting beans
Right after bowing to the king, ego faces away from him. This
issue was already present in 1.7.0. Could probably get solved
later via script patcher.
This commit is contained in:
Martin Kiewitz 2016-02-14 15:17:29 +01:00
parent eaad4208c7
commit 8eefa4e2b5
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engines/agi/op_cmd.cpp
View File

@ -895,6 +895,8 @@ void cmdSetSimple(AgiGame *state, AgiEngine *vm, uint8 *parameter) {
// it's called with parameter 16.
// Original interpreter doesn't seem to play any sound.
// TODO: Figure out what's going on. It can't be automatic saving of course.
// Also getting called in KQ1, when planting beans - parameter 12.
// And when killing the witch - parameter 40.
if ((getVersion() < 0x2425) || (getVersion() == 0x2440)) {
// was not available before 2.2425, but also not available in 2.440
warning("set.simple called, although not available for current AGI version");

6
engines/agi/view.cpp
View File

@ -482,7 +482,11 @@ void AgiEngine::setLoop(ScreenObjEntry *screenObj, int16 loopNr) {
// requested loop not existant
// instead of error()ing out, we instead clip it
// At least required for possibly Manhunter 1 according to previous comment when leaving the arcade machine
// TODO: check MH1
// TODO: Check MH1
// TODO: This causes an issue in KQ1, when bowing to the king in room 53
// Ego will face away from the king, because the scripts set the loop first and then the view
// Loop is corrected by us, because at that time it's invalid. Was already present in 1.7.0
// We should probably script-patch it out.
int16 requestedLoopNr = loopNr;
loopNr = screenObj->loopCount - 1;