libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-04-12 03:36:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Added FIXME for the _haveMsg hack

Browse Source 
svn-id: r17720
This commit is contained in:
Max Horn 2005-04-20 20:20:31 +00:00
parent 6e3fd4527e
commit 9216ca4ed5
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
scumm/string.cpp
View File

@ -329,6 +329,7 @@ void ScummEngine::CHARSET_1() {
a->startAnimActor(frme); a->startAnimActor(frme);
break; break;
case 10: case 10:
// Note the similarity to the code in unkMessage1()
talk_sound_a = buffer[0] | (buffer[1] << 8) | (buffer[4] << 16) | (buffer[5] << 24); talk_sound_a = buffer[0] | (buffer[1] << 8) | (buffer[4] << 16) | (buffer[5] << 24);
talk_sound_b = buffer[8] | (buffer[9] << 8) | (buffer[12] << 16) | (buffer[13] << 24); talk_sound_b = buffer[8] | (buffer[9] << 8) | (buffer[12] << 16) | (buffer[13] << 24);
buffer += 14; buffer += 14;
@ -339,6 +340,10 @@ void ScummEngine::CHARSET_1() {
// This is actually a hack added by ScummVM; the original did // This is actually a hack added by ScummVM; the original did
// subtitle hiding in some other way. I am not sure exactly // subtitle hiding in some other way. I am not sure exactly
// how, though. // how, though.
// FIXME: This is actually a rather ugly hack, and we should consider
// replacing it with something better; problem is that _haveMsg is saved,
// so we need to cope with old save games if we ever change this.
// And BTW Fingolfin was responsible for this silly bad hack. Stupid me! :-).
if (_haveMsg == 0xFF) if (_haveMsg == 0xFF)
_haveMsg = 0xFE; _haveMsg = 0xFE;
break; break;