libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2024-12-14 21:59:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

TIMER: Add a comment to explain why we remove the name in removeTimerProc.

Browse Source
This commit is contained in:
Johannes Schickel 2011-08-10 18:42:19 +02:00
parent c443f113ed
commit 930f626dab
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
backends/timer/default/default-timer.cpp
View File

@ -162,6 +162,18 @@ void DefaultTimerManager::removeTimerProc(TimerProc callback) {
}
}
// We need to remove all names referencing the timer proc here.
//
// Else we run into troubles, when the client code removes and readds timer
// callbacks.
//
// Another issues occurs when one plays a game with ALSA as music driver,
// does RTL and starts a different engine game with ALSA as music driver.
// In this case the MPU401 code will add different timer procs with the
// same name, resulting in two different callbacks added with the same
// name and causing installTimerProc to error out.
// A good test case is running a SCUMM with ALSA output and then a KYRA
// game for example.
for (TimerSlotMap::iterator i = _callbacks.begin(), end = _callbacks.end(); i != end; ++i) {
if (i->_value == callback)
_callbacks.erase(i);