From 9823cbe1ea724f7fbadd11676d082ce97e298078 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Sun, 25 Feb 2007 00:04:35 +0000 Subject: [PATCH] Added TODO: Sword1's MusicHandle::play etc. should be rewritten to take advantage of the enhanced compressed audio stream code svn-id: r25841 --- engines/sword1/music.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/engines/sword1/music.cpp b/engines/sword1/music.cpp index 333c4657055..41ca36e3061 100644 --- a/engines/sword1/music.cpp +++ b/engines/sword1/music.cpp @@ -130,6 +130,14 @@ Audio::AudioStream *MusicHandle::createAudioSource(void) { } bool MusicHandle::play(const char *fileBase, bool loop) { +/* +TODO/FIXME: This should be rewritten to make use of the new audio stream factories. +In particular, it should take advantage of the looping capabilities; and it +should avoid reading all the data into memory (by not using the old factory functions). +Essentially, it seems to me as if we could get rid of createAudioSource(). + +Maybe it could even be change to use AudioStream::openStreamFile. +*/ char fileName[30]; stop(); _musicMode = MusicNone;