libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-02-04 09:56:30 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

DIRECTOR: Fix unchecked return value

Browse Source 
getChildren returns false when not succesful, i.e. meaning we can bail
out of the loop iteration.

Fixes COVERITY: 1462418
This commit is contained in:
Roland van Laar 2022-10-07 17:05:46 +02:00
parent 891fa08f15
commit 9aafdcf976
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
engines/director/util.cpp
View File

@ -421,7 +421,9 @@ bool testPath(Common::String &path, bool directory) {
if (directory_list.empty() && !directory) {
mode = Common::FSNode::kListAll;
}
d.getChildren(fslist, mode);
bool hasChildren = d.getChildren(fslist, mode);
if (!hasChildren)
continue;
bool exists = false;
for (Common::FSList::iterator i = fslist.begin(); i != fslist.end(); ++i) {