libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-02-07 11:27:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

It seems that the SCI GUI code tries to show rectangles with negative height. Added some sanity checks for this, but the *real* problem lies elsewhere

Browse Source 
svn-id: r39451
This commit is contained in:
Filippos Karapetis 2009-03-16 19:19:59 +00:00
parent 7cd1ac5231
commit 9ec640633d
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
engines/sci/gfx/gfx_widgets.cpp
View File

@ -491,6 +491,12 @@ static int _gfxwop_primitive_equals(gfxw_widget_t *widget, gfxw_widget_t *other)
oprim = (gfxw_primitive_t *) other;
// FIXME: I'm not even sure why this happens...
if (wprim->bounds.height < 0 || oprim->bounds.height < 0) {
warning("_gfxwop_primitive_equals: height < 0");
return 0;
}
if (!toCommonRect(wprim->bounds).equals(toCommonRect(oprim->bounds)))
return 0;
@ -1970,6 +1976,11 @@ int gfxw_widget_matches_snapshot(gfxw_snapshot_t *snapshot, gfxw_widget_t *widge
if (!GFXW_IS_CONTAINER(widget) && widget->parent) {
bounds.x += widget->parent->bounds.x;
bounds.y += widget->parent->bounds.y;
// FIXME: I'm not even sure why this happens...
if (bounds.height < 0) {
warning("gfxw_widget_matches_snapshot: height < 0");
return 0;
}
}
return ((widget->serial >= free_above_eq || widget->serial < free_below) &&