libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-01-26 20:59:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

SCI: Clarify comment from rev 5654e12 further

Browse Source
This commit is contained in:
Willem Jan Palenstijn 2011-04-28 12:00:27 +02:00
parent 3e01d35281
commit 9f74a6eda2
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
engines/sci/sound/soundcmd.cpp
View File

@ -345,10 +345,15 @@ reg_t SoundCommandParser::kDoSoundFade(int argc, reg_t *argv, reg_t acc) {
musicSlot->fadeStep = volume > musicSlot->fadeTo ? -5 : 5;
musicSlot->fadeTickerStep = argv[2].toUint16() * 16667 / _music->soundGetTempo();
musicSlot->fadeTicker = 0;
// TODO: We handle this as a bit field (i.e. containing values 0 and 1),
// but some games pass other values here as well (e.g. some KQ6 scripts
// pass 3 here)
musicSlot->stopAfterFading = (argc == 5) ? (argv[4].toUint16() != 0) : false;
if (argc == 5) {
// TODO: We currently treat this argument as a boolean, but may
// have to handle different non-zero values differently. (e.g.,
// some KQ6 scripts pass 3 here)
musicSlot->stopAfterFading = (argv[4].toUint16() != 0);
} else {
musicSlot->stopAfterFading = false;
}
// WORKAROUND/HACK: In the labyrinth in KQ6, when falling in the pit and
// lighting the lantern, the game scripts perform a fade in of the game