libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-04-02 14:51:40 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

CLOUD: Fix Cppcheck warnings

Browse Source
This commit is contained in:
Alexander Tkachev 2016-07-20 17:30:19 +06:00
parent c7fe842f9a
commit a449ddce15
5 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
backends/cloud/cloudmanager.cpp
View File

@ -240,6 +240,7 @@ void CloudManager::connectStorage(uint32 index, Common::String code) {
// in these constructors Storages request token using the passed code
// when the token is received, they call replaceStorage()
// or removeStorage(), if some error occurred
// thus, no memory leak happens
}
void CloudManager::printBool(Storage::BoolResponse response) const {

2
backends/cloud/dropbox/dropboxstorage.cpp
View File

@ -135,7 +135,7 @@ Networking::Request *DropboxStorage::streamFileById(Common::String path, Network
Networking::NetworkReadStreamResponse response = request->execute();
if (callback) (*callback)(response);
return response.request;
return response.request; // no leak here, response.request == request
}
Networking::Request *DropboxStorage::createDirectory(Common::String path, BoolCallback callback, Networking::ErrorCallback errorCallback) {

4
backends/cloud/dropbox/dropboxuploadrequest.cpp
View File

@ -137,10 +137,10 @@ void DropboxUploadRequest::partUploadedCallback(Networking::JsonResponse respons
//debug("%s", json->stringify(true).c_str());
if (object.contains("error") || object.contains("error_summary")) {
warning("Dropbox returned error: %s", object.getVal("error_summary")->asString().c_str());
delete json;
warning("Dropbox returned error: %s", object.getVal("error_summary")->asString().c_str());
error.response = json->stringify(true);
finishError(error);
delete json;
return;
}

2
backends/cloud/googledrive/googledriveuploadrequest.cpp
View File

@ -266,9 +266,9 @@ void GoogleDriveUploadRequest::partUploadedCallback(Networking::JsonResponse res
if (object.contains("error")) {
warning("GoogleDrive returned error: %s", json->stringify(true).c_str());
delete json;
error.response = json->stringify(true);
finishError(error);
delete json;
return;
}

2
backends/cloud/onedrive/onedriveuploadrequest.cpp
View File

@ -127,9 +127,9 @@ void OneDriveUploadRequest::partUploadedCallback(Networking::JsonResponse respon
if (object.contains("error")) {
warning("OneDrive returned error: %s", json->stringify(true).c_str());
delete json;
error.response = json->stringify(true);
finishError(error);
delete json;
return;
}