libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-02-06 19:08:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

SUPERNOVA: Initializes clickField.next with 0

Browse Source 
It seems it is possible that some objects or subsequent click fields
'pointed' to by next are outside of the initialized range and are
expected to be zeroed. This would explain the non-deterministic freezes
I experienced.
This commit is contained in:
Joseph-Eugene Winzer 2017-07-23 03:00:02 +02:00 committed by Thierry Crozat
parent 83523ebbdc
commit aa447e81bc
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
engines/supernova/graphics.cpp
View File

@ -98,6 +98,9 @@ bool MSNImageDecoder::loadStream(Common::SeekableReadStream &stream) {
}
_numClickFields = stream.readByte();
for (int i = 0; i < kMaxClickFields; ++i) {
_clickField[i].next = 0;
}
for (int i = 0; i < _numClickFields; ++i) {
_clickField[i].x1 = stream.readUint16LE();
_clickField[i].x2 = stream.readUint16LE();