libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-01-24 11:36:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

PRINCE: Fix potential out-of-bounds write (CID 1248504)

Browse Source 
There are kMaxTexts text slots, so kMaxTexts itself is not valid.
This commit is contained in:
Torbjörn Andersson 2014-10-25 20:52:14 +02:00
parent 9c885719fd
commit b6302c6e51
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
engines/prince/prince.cpp
View File

@ -730,8 +730,8 @@ bool PrinceEngine::loadSample(uint32 sampleSlot, const Common::String &streamNam
bool PrinceEngine::loadVoice(uint32 slot, uint32 sampleSlot, const Common::String &streamName) {
debugEngine("Loading wav %s slot %d", streamName.c_str(), slot);
if (slot > kMaxTexts) {
error("Text slot bigger than MAXTEXTS %d", kMaxTexts);
if (slot >= kMaxTexts) {
error("Text slot bigger than MAXTEXTS %d", kMaxTexts - 1);
return false;
}