libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2024-12-17 07:07:10 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

BASE: PLUGINS: Deprecate improper usage of unloadPluginsExcept

Browse Source
This commit is contained in:
aryanrawlani28 2020-08-03 05:22:11 +05:30 committed by Eugene Sandulenko
parent 73cc973ad7
commit bdafdf220d
1 changed files with 3 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
base/plugins.cpp
View File

@ -491,73 +491,19 @@ void PluginManager::unloadPluginsExcept(PluginType type, const Plugin *plugin, b
// If someone calls this function with a nullptr Plugin, we clear everything, and no need to search
// for individual plugin.
if (plugin) {
if (type != plugin->getType() && type != PLUGIN_TYPE_ENGINE) {
if (type != plugin->getType()) {
warning("Plugins: unloadPluginExcept: mismatching type of plugins requested to unload. Operation not carried out.");
return;
}
Common::String enginePluginTitle("");
bool toDelete = false;
if (type == PLUGIN_TYPE_ENGINE) {
/**
* We've got in a plugin of type MetaEngine, and we want to keep
* the relevant plugin of Engine type in memory.
* To do this, we first construct a name from the given MetaEngine.
*/
#ifdef PLUGIN_PREFIX
enginePluginTitle += PLUGIN_PREFIX;
#endif
enginePluginTitle += Common::String(plugin->getEngineId());
#ifdef PLUGIN_SUFFIX
enginePluginTitle += PLUGIN_SUFFIX;
#endif
}
for (PluginList::iterator p = _pluginsInMem[type].begin(); p != _pluginsInMem[type].end(); ++p) {
if (type == PLUGIN_TYPE_ENGINE) {
Common::String enginePluginFilename((*p)->getFileName());
/**
* Take the ending of the filename, and subtract it with the size of enginePluginTitle.
* This should effectively cancel out directory names and exactly leave the plugin filename
* ONLY for the one we require. That's why we do a equals call.
* Example: We got the request to unload engine of AGI, and were given a AGIMetaEngine.
* So, plugins/agi.dll will beome agi.dll (fetched by getFileName) and will try
* to match to our generated enginePluginTitle from the plugin we got. (A metaengine type plugin)
* This will then pass the check and be the only one loaded in memory.
*/
if (enginePluginFilename.size() > enginePluginTitle.size()) {
Common::String::const_iterator beginItr = enginePluginFilename.end() - enginePluginTitle.size();
Common::String strippedFileName(beginItr, enginePluginFilename.end());
if (strippedFileName.equalsIgnoreCase(enginePluginTitle)) {
found = *p;
} else {
toDelete = true;
}
} else {
toDelete = true;
}
if (*p == plugin) {
found = *p;
} else {
// The type is something other than a engine type.
if (*p == plugin) {
found = *p;
} else {
toDelete = true;
}
}
if (toDelete) {
(*p)->unloadPlugin();
if (deletePlugin) {
delete *p;
}
toDelete = false;
}
}
}