libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-01-10 03:40:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

SCUMM: DOTT: Add more context about bug no. 1831 (WORKAROUND)

Browse Source 
More background about this original scripting issue was given by
Oliver Franzke from Double Fine during the GDC17 conference.

Documenting any upstream explanation about original bugs is probably
good for SCUMM historians!

https://www.p1xelcoder.com/resources/GDC_2017_Remastering_DotT_and_Grim.pdf
https://www.youtube.com/watch?v=HqWrdIf69M8&t=1340
This commit is contained in:
Donovan Watteau 2023-03-08 21:08:19 +01:00
parent fd85df270f
commit cc034f60be
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
engines/scumm/room.cpp
View File

@ -474,11 +474,17 @@ void ScummEngine::setupRoomSubBlocks() {
// WORKAROUND bug #1831: The dreaded DOTT "Can't get teeth" bug
// makes it impossible to go on playing w/o cheating in some way.
// It's not quite clear what causes it, but the effect is that object
// 182, the teeth, are still in class 32 (kObjectClassUntouchable),
// when they shouldn't be. Luckily, bitvar69 is set to 1 if and only if
// the teeth are trapped and have not yet been taken by the player. So
// we can make use of that fact to fix the object class of obj 182.
// Before the GDC17 conference where Oliver Franzke gave more
// background about this, it wasn't quite clear what caused this issue,
// but the effect is that object 182, the teeth, are still in class 32
// (kObjectClassUntouchable), when they shouldn't be. Luckily, bitvar69
// (teeth-caught) is set to 1 if and only if the teeth are trapped and
// have not yet been taken by the player. So we can make use of that
// fact to fix the object class of obj 182. This should match what the
// 2016 remaster did.
//
// Not using `_enableEnhancements` since leaving the room too quickly
// would just make this puzzle impossible to complete.
if (_game.id == GID_TENTACLE && _roomResource == 26 && readVar(0x8000 + 69)
&& getClass(182, kObjectClassUntouchable)) {
putClass(182, kObjectClassUntouchable, 0);