libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-01-26 12:48:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

GRAPHICS: Fix PICT buffer overflow

Browse Source
This commit is contained in:
Matthew Hoops 2011-10-07 11:11:00 -04:00
parent 172e97da15
commit deab5b2875
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
graphics/pict.cpp
View File

@ -337,7 +337,11 @@ void PictDecoder::unpackBitsRect(Common::SeekableReadStream *stream, bool hasPal
_outputSurface = new Graphics::Surface();
_outputSurface->create(width, height, (bytesPerPixel == 1) ? PixelFormat::createFormatCLUT8() : _pixelFormat);
byte *buffer = new byte[width * height * bytesPerPixel];
// Create an temporary buffer, but allocate a bit more than we need to avoid overflow
// (align it to the next highest two-byte packed boundary, which may be more unpacked,
// as m68k and therefore QuickDraw is word-aligned)
byte *buffer = new byte[width * height * bytesPerPixel + (8 * 2 / packBitsData.pixMap.pixelSize)];
// Read in amount of data per row
for (uint16 i = 0; i < packBitsData.pixMap.bounds.height(); i++) {