libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-01-24 11:36:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

MYST3: Mark an opcode as useless

Browse Source
This commit is contained in:
Bastien Bouclet 2014-03-06 21:02:38 +01:00
parent c87b6f859e
commit e04d06a138
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
engines/myst3/script.cpp
View File

@ -46,6 +46,14 @@ Script::Script(Myst3Engine *vm):
#define OP_4(op, x, type1, type2, type3, type4) _commands.push_back(Command(op, &Script::x, #x, 4, type1, type2, type3, type4))
#define OP_5(op, x, type1, type2, type3, type4, type5) _commands.push_back(Command(op, &Script::x, #x, 5, type1, type2, type3, type4, type5))
// TODO: Implement these remaining opcodes
// 5: I'm pretty sure it's useless
// 144: drawTransition
// 213: soundPlayEffectFadeArray
// 214, 215, 216, 217: setupRandomSound
// 236: setupSoundForMovie
// 247: quit
OP_0( 0, badOpcode );
OP_1( 4, nodeCubeInit, kEvalValue );
OP_5( 6, nodeCubeInitIndex, kVar, kEvalValue, kEvalValue, kEvalValue, kEvalValue );
@ -201,6 +209,7 @@ Script::Script(Myst3Engine *vm):
OP_1(164, changeNode, kValue );
OP_2(165, changeNodeRoom, kValue, kValue );
OP_3(166, changeNodeRoomAge, kValue, kValue, kValue );
OP_0(168, uselessOpcode );
OP_1(169, drawXFrames, kValue );
OP_1(171, drawWhileCond, kCondition );
OP_1(172, whileStart, kCondition );
@ -368,6 +377,16 @@ void Script::badOpcode(Context &c, const Opcode &cmd) {
error("Trying to run invalid opcode %d", cmd.op);
}
void Script::uselessOpcode(Context &c, const Opcode &cmd) {
debugC(kDebugScript, "Opcode %d: Useless opcode", cmd.op);
// List of useless opcodes
// 167 and 168 form a pair. 168 resets what 167 sets up.
// Since 167 is never used, 168 is marked as useless.
}
void Script::nodeCubeInit(Context &c, const Opcode &cmd) {
debugC(kDebugScript, "Opcode %d: Node cube init %d", cmd.op, cmd.args[0]);

1
engines/myst3/script.h
View File

@ -96,6 +96,7 @@ private:
void runScriptForVarDrawFramesHelper(uint16 var, int32 startValue, int32 endValue, uint16 script, int32 numFrames);
DECLARE_OPCODE(badOpcode);
DECLARE_OPCODE(uselessOpcode);
DECLARE_OPCODE(nodeCubeInit);
DECLARE_OPCODE(nodeCubeInitIndex);