libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2024-12-22 18:02:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

SCUMM: Added FIXME to our old AdLib resource conversion code.

Browse Source 
We handle command 0x80 incorrectly, which results in sound effects never
looping. This is the cause for bug #2027877 for example. I add this FIXME
since it is (probably) non-trivial to fix and so it won't be forgotten.
This commit is contained in:
Johannes Schickel 2011-08-03 05:06:29 +02:00
parent 7e7e606919
commit e1d881a227
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engines/scumm/sound.cpp
View File

@ -1997,6 +1997,14 @@ static void convertADResource(ResourceManager *res, const GameSettings& game, Re
break;
case 0x80:
// FIXME: This is incorrect. The original uses 0x80 for
// looping a single channel. We currently interpret it as stop
// thus we won't get looping for sound effects. It should
// always jump to the start of the channel.
//
// Since we convert the data to MIDI and we can not ony loop a
// single channel via MIDI fixing this will require some more
// thought.
track_time[ch] = -1;
src_ptr ++;
break;